Skip to content

Temporarily allow the TSan (free-threading) job to fail #152173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 4 commits into from
Jul 7, 2026
Merged

Temporarily allow the TSan (free-threading) job to fail #152173

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80ab33d
Skip `test_abstractmethod_integration` on free-threading
StanFromIreland Jun 25, 2026
d2782d5
Revert "Skip `test_abstractmethod_integration` on free-threading"
StanFromIreland Jun 25, 2026
24e9fce
Allow the job to fail instead
StanFromIreland Jun 25, 2026
ea7a9af
Merge branch 'main' into test_abstractmethod_integration
StanFromIreland Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow the job to fail instead
  • Loading branch information
@StanFromIreland
StanFromIreland committed Jun 25, 2026
commit 24e9fce207a819317f99bd3206f700388b4a3361
14 changes: 13 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,6 @@ jobs:
- Thread
Comment thread
StanFromIreland marked this conversation as resolved.
free-threading:
- false
- true
sanitizer:
- TSan
include:
Expand All @@ -570,6 +569,17 @@ jobs:
sanitizer: ${{ matrix.sanitizer }}
free-threading: ${{ matrix.free-threading }}

# XXX: Temporarily allow this job to fail to not block PRs.
Comment thread
StanFromIreland marked this conversation as resolved.
build-san-free-threading:
# ${{ '' } is a hack to nest jobs under the same sidebar category.
name: Sanitizers${{ '' }} # zizmor: ignore[obfuscation]
Comment thread
webknjaz marked this conversation as resolved.
needs: build-context
if: needs.build-context.outputs.run-ubuntu == 'true'
uses: ./.github/workflows/reusable-san.yml
with:
sanitizer: TSan
free-threading: true

cross-build-linux:
name: Cross build Linux
runs-on: ubuntu-latest
Expand Down Expand Up @@ -673,6 +683,7 @@ jobs:
- test-hypothesis
- build-asan
- build-san
- build-san-free-threading
- cross-build-linux
- cifuzz
if: always()
Expand All @@ -684,6 +695,7 @@ jobs:
allowed-failures: >-
build-android,
build-emscripten,
build-san-free-threading,
build-windows-msi,
build-ubuntu-ssltests,
test-hypothesis,
Expand Down
Loading