Skip to content

gh-152157: Reject empty fraction before timezone in C fromisoformat #152161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 4 commits into from
Jul 1, 2026
Merged

gh-152157: Reject empty fraction before timezone in C fromisoformat #152161

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54ecfa5
gh-152157: Reject empty fraction before timezone in C fromisoformat
tonghuaroot Jun 25, 2026
4dc17e2
Some minor PEP 7 fixes
StanFromIreland Jun 30, 2026
e03e051
Succinct news entry
StanFromIreland Jun 30, 2026
bfa84c3
Merge branch 'main' into fix-c-fromisoformat-empty-fraction-tz
StanFromIreland Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some minor PEP 7 fixes
  • Loading branch information
@StanFromIreland
StanFromIreland committed Jun 30, 2026
commit 4dc17e25bf1d6cd293e6689599a13df99be463d8
8 changes: 5 additions & 3 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ parse_hh_mm_ss_ff(const char *tstr, const char *tstr_end, int *hour,

if (c == '.' || c == ',') {
if (i < 2) {
return -3; // Decimal mark on hour or minute
return -3; // Decimal mark on hour or minute
}
if (p >= p_end) {
return -3; // Decimal mark not followed by any digit
Expand All @@ -1051,9 +1051,11 @@ parse_hh_mm_ss_ff(const char *tstr, const char *tstr_end, int *hour,
return -4; // Malformed microsecond separator
}
continue;
} else if (!has_separator) {
}
else if (!has_separator) {
--p;
} else {
}
else {
return -4; // Malformed time separator
}
}
Expand Down
Loading