Skip to content

bpo-37785: argparse uses %s in gettext calls causing xgettext warnings #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulienPalard merged 3 commits into from
Sep 13, 2019
Merged

bpo-37785: argparse uses %s in gettext calls causing xgettext warnings #15161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92af9d0
bpo-37785: argparse uses %s in gettext calls causing xgettext warnings
kulikjak Aug 7, 2019
30abc07
Minor improvements
kulikjak Aug 12, 2019
77c9863
Minor documentation fix
kulikjak Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,8 +1207,9 @@ def __call__(self, string):
return open(string, self._mode, self._bufsize, self._encoding,
self._errors)
except OSError as e:
message = _("can't open '%s': %s")
raise ArgumentTypeError(message % (string, e))
args = {'filename': string, 'error': e}
message = _("can't open '%(filename)s': %(error)s")
raise ArgumentTypeError(message % (args))
Comment thread
kulikjak marked this conversation as resolved.
Outdated
Comment thread
kulikjak marked this conversation as resolved.
Outdated

def __repr__(self):
args = self._mode, self._bufsize
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-08-07-14-49-22.bpo-37785.y7OlT8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix xgettext warnings in the argparse module.
Comment thread
kulikjak marked this conversation as resolved.
Outdated