Skip to content

[3.14] gh-150913: Fix sqlite3.Blob validation for empty slice assignment (GH-150915) #150924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jun 4, 2026
Merged

[3.14] gh-150913: Fix sqlite3.Blob validation for empty slice assignment (GH-150915) #150924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-150913: Fix sqlite3.Blob validation for empty slice assignment (GH… 
…-150915)

ass_subscript_slice() returned early when the computed slice length
was zero, bypassing validation performed for non-empty slices.
(cherry picked from commit fc9c4db)

Co-authored-by: Jiseok CHOI <jiseok.dev@gmail.com>
  • Loading branch information
@ever0de @miss-islington
ever0de authored and miss-islington committed Jun 4, 2026
commit 8c3035351d9ec10a8703e757a51b78a0b19711f9
12 changes: 12 additions & 0 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,6 +1408,18 @@ def test_blob_set_empty_slice(self):
self.blob[0:0] = b""
self.assertEqual(self.blob[:], self.data)

def test_blob_set_empty_slice_wrong_type(self):
with self.assertRaises(TypeError):
self.blob[5:5] = None

def test_blob_set_empty_slice_wrong_size(self):
with self.assertRaisesRegex(IndexError, "wrong size"):
self.blob[5:5] = b"123"

def test_blob_set_empty_slice_correct(self):
self.blob[5:5] = b""
self.assertEqual(self.blob[:], self.data)

def test_blob_set_slice_with_skip(self):
self.blob[0:10:2] = b"12345"
actual = self.cx.execute("select b from test").fetchone()[0]
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-06-04-21-49-18.gh-issue-150913.EmptyBl.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix :class:`sqlite3.Blob` slice assignment to raise
:exc:`TypeError` and :exc:`IndexError` for type and size mismatches
respectively, even when the target slice is empty.
16 changes: 10 additions & 6 deletions Modules/_sqlite/blob.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,21 +524,25 @@ ass_subscript_slice(pysqlite_Blob *self, PyObject *item, PyObject *value)
return -1;
}

if (len == 0) {
return 0;
}

Py_buffer vbuf;
if (PyObject_GetBuffer(value, &vbuf, PyBUF_SIMPLE) < 0) {
return -1;
}

int rc = -1;
if (vbuf.len != len) {
PyErr_SetString(PyExc_IndexError,
"Blob slice assignment is wrong size");
PyBuffer_Release(&vbuf);
return -1;
}
else if (step == 1) {

if (len == 0) {
PyBuffer_Release(&vbuf);
return 0;
}

int rc = -1;
if (step == 1) {
rc = inner_write(self, vbuf.buf, len, start);
}
else {
Expand Down
Loading