Skip to content

bpo-37531: Fix regrtest timeout for subprocesses #15072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 11 commits into from
Aug 14, 2019
Merged

bpo-37531: Fix regrtest timeout for subprocesses #15072

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
172ca99
Fix regrtest timeout for subprocesses
Jul 9, 2019
35b87eb
Some edits to test
Jul 9, 2019
d8df7ac
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 9, 2019
a55a6af
Revert file mode changes
Jul 18, 2019
fcb7b73
Report stdout/stderr on timeout or child error
vstinner Jul 31, 2019
e586373
Rewrite the NEWS entry
vstinner Aug 1, 2019
522555f
format_test_result(): add timeout duration
vstinner Aug 14, 2019
96bbeb3
Add an unit test
vstinner Aug 14, 2019
e2b3280
Enhance unit test
vstinner Aug 14, 2019
46bfdfe
Fix typo
vstinner Aug 14, 2019
f06ae0b
Fix is_failed(): TIMEOUT is considered as a fail
vstinner Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some edits to test
  • Loading branch information
Joannah nanjekye @vstinner
Joannah nanjekye authored and vstinner committed Aug 14, 2019
commit 35b87eb63979b1d781f7b485b717b722563c6c50
5 changes: 5 additions & 0 deletions Lib/test/libregrtest/runtest_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ def _runtest(self, test_name):
try:
stdout, stderr = popen.communicate(timeout=self.ns.timeout)
except subprocess.TimeoutExpired:
if self._killed:
# kill() has been called: communicate() fails
# on reading closed stdout/stderr
raise ExitThread
result, stdout, stderr, err_msg = self.time_result(test_name, TIMEOUT)
raise
except OSError:
if self._killed:
# kill() has been called: communicate() fails
Expand Down