Skip to content

gh-145411: Add runtime (now: unix only) control to Tachyon #149958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maurycy wants to merge 8 commits into
base: main
Choose a base branch
from
+868 −64
Open

gh-145411: Add runtime (now: unix only) control to Tachyon #149958

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed77e71
here goes my sunday
maurycy May 17, 2026
1bc72ec
blurb
maurycy May 17, 2026
71c6b97
skip sample_interval_usec in v0
maurycy May 17, 2026
0fe9ad1
from ... contextlib
maurycy May 17, 2026
005098d
accidentially removed comment
maurycy May 17, 2026
63447d3
fix ci
maurycy May 18, 2026
20bc76b
after sleeping over: 1-100ms latency here is ok
maurycy May 18, 2026
44fa622
Merge branch 'main' into tachyon-runtime-socket
maurycy Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
from ... contextlib
  • Loading branch information
@maurycy
maurycy committed May 17, 2026
commit 0fe9ad10f334511e5ed1486aa3502e9cb092424c
11 changes: 5 additions & 6 deletions Lib/profiling/sampling/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Command-line interface for the sampling profiler."""

import argparse
import contextlib
import importlib.util
import locale
import os
Expand All @@ -12,7 +11,7 @@
import sys
import time
import webbrowser
from contextlib import nullcontext
from contextlib import ExitStack, nullcontext

from .errors import (
SamplingUnknownProcessError,
Expand Down Expand Up @@ -1202,7 +1201,7 @@ def _handle_attach(args):
)

server = None
with contextlib.ExitStack() as stack:
with ExitStack() as stack:

@maurycy maurycy May 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping should-be-soon-to-be-added signal (SIGUSR1, SIGUSR2 for enabling or disabling?) support in mind.

if args.control:
server = ControlServer(args.control)
try:
Expand Down Expand Up @@ -1319,7 +1318,7 @@ def _handle_run(args):
)

server = None
with contextlib.ExitStack() as stack:
with ExitStack() as stack:
stack.enter_context(_get_child_monitor_context(args, process.pid))

def _terminate_main_subprocess():
Expand Down Expand Up @@ -1380,7 +1379,7 @@ def _handle_live_attach(args, pid):

# Sample in live mode
server = None
with contextlib.ExitStack() as stack:
with ExitStack() as stack:
if args.control:
server = ControlServer(args.control)
try:
Expand Down Expand Up @@ -1438,7 +1437,7 @@ def _handle_live_run(args):
# Profile the subprocess in live mode
server = None
try:
with contextlib.ExitStack() as stack:
with ExitStack() as stack:
if args.control:
server = ControlServer(args.control)
try:
Expand Down
Loading