Skip to content

gh-149584: Fix excessive overhead in the Tachyon profiler regarding the cache behavior #149649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 11 commits into from
May 20, 2026
Merged

gh-149584: Fix excessive overhead in the Tachyon profiler regarding the cache behavior #149649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c5520d3
gh-149584: Avoid page reads for hot profiler structs
pablogsal May 10, 2026
8be8d7d
gh-149584: Track live remote page cache entries
pablogsal May 10, 2026
5dc0309
gh-149584: Batch predicted profiler reads
pablogsal May 10, 2026
c69a0f3
gh-149584: Reuse profiler result objects
pablogsal May 10, 2026
7a85c9a
gh-149584: Add NEWS for Tachyon profiler overhead fix
pablogsal May 10, 2026
46a0b2c
Address review feedback
pablogsal May 12, 2026
f7fe3be
Add async benchmark modes
pablogsal May 12, 2026
2995187
cleanp
pablogsal May 12, 2026
d576d38
small cleanp
pablogsal May 13, 2026
05799a7
fixup! small cleanp
May 19, 2026
4245b13
fixup! fixup! small cleanp
May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-149584: Avoid page reads for hot profiler structs 
Use exact remote reads for interpreter state, thread state, and
interpreter frame structs instead of pulling full remote pages into the
profiler page cache. This matches the core change from
#149585.
  • Loading branch information
@pablogsal
pablogsal committed May 10, 2026
commit c5520d361c87a7993799e3e98db335d83aec7070
2 changes: 1 addition & 1 deletion Modules/_remote_debugging/frames.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ parse_frame_object(
char frame[SIZEOF_INTERP_FRAME];
*address_of_code_object = 0;

Py_ssize_t bytes_read = _Py_RemoteDebug_PagedReadRemoteMemory(
Py_ssize_t bytes_read = _Py_RemoteDebug_ReadRemoteMemory(
&unwinder->handle,
address,
SIZEOF_INTERP_FRAME,
Expand Down
2 changes: 1 addition & 1 deletion Modules/_remote_debugging/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ _remote_debugging_RemoteUnwinder_get_stack_trace_impl(RemoteUnwinderObject *self
while (current_interpreter != 0) {
// Read interpreter state to get the interpreter ID
char interp_state_buffer[INTERP_STATE_BUFFER_SIZE];
if (_Py_RemoteDebug_PagedReadRemoteMemory(
if (_Py_RemoteDebug_ReadRemoteMemory(
&self->handle,
current_interpreter,
INTERP_STATE_BUFFER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion Modules/_remote_debugging/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ unwind_stack_for_thread(
StackChunkList chunks = {0};

char ts[SIZEOF_THREAD_STATE];
int bytes_read = _Py_RemoteDebug_PagedReadRemoteMemory(
int bytes_read = _Py_RemoteDebug_ReadRemoteMemory(
&unwinder->handle, *current_tstate, (size_t)unwinder->debug_offsets.thread_state.size, ts);
if (bytes_read < 0) {
set_exception_cause(unwinder, PyExc_RuntimeError, "Failed to read thread state");
Expand Down