Skip to content

gh-149527: fix creation of temporary socket files post GH-148578 #149597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 11 commits into from
Oct 22, 2026
Merged

gh-149527: fix creation of temporary socket files post GH-148578 #149597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
77c28e3
gh-149527: fix creation of temporary socket files post GH-148578
picnixz May 9, 2026
ab905ba
Update Lib/multiprocessing/util.py
picnixz May 9, 2026
6a74bea
add tests
picnixz Aug 15, 2026
6a78f3f
Merge branch 'main' into fix/forkserver/path-too-long-149527
picnixz Aug 15, 2026
0bed495
amend
picnixz Aug 15, 2026
3388fa1
Merge branch 'main' into fix/forkserver/path-too-long-149527
picnixz Oct 19, 2026
6da8c2a
Update Lib/multiprocessing/util.py
picnixz Oct 19, 2026
e930a6a
Update Lib/multiprocessing/util.py
picnixz Oct 19, 2026
59dacf9
fix tests on macOS
picnixz Oct 19, 2026
094971f
Merge branch 'main' into fix/forkserver/path-too-long-149527
picnixz Oct 21, 2026
5f4add5
Update test_misc.py
picnixz Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
  • Loading branch information
@picnixz
picnixz committed Aug 15, 2026
commit 6a74bea2fae8ca16a09dd653b3069ea30eec222c
3 changes: 3 additions & 0 deletions Lib/multiprocessing/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def is_abstract_socket_namespace(address):
len(os.path.sep) + _TMPPYMP_PREFIXLEN + _TMPPYMP_SUFFIXLEN +
len(os.path.sep) + _TMPSOCK_PREFIXLEN + _TMPSOCK_SUFFIXLEN
)
assert _SUN_PATH_LEN_RESERVED < _SUN_PATH_MAX
Comment thread
picnixz marked this conversation as resolved.
Outdated


def _remove_temp_dir(rmtree, tempdir):
Expand All @@ -184,6 +185,7 @@ def _remove_temp_dir(rmtree, tempdir):
if current_process is not None:
current_process._config['tempdir'] = None


def _get_base_temp_dir(tempfile):
"""Get a temporary directory where socket files will be created.

Expand Down Expand Up @@ -232,6 +234,7 @@ def _get_base_temp_dir(tempfile):
assert len(base_system_tempdir) + _SUN_PATH_LEN_RESERVED < _SUN_PATH_MAX
return base_system_tempdir


def get_temp_dir():
# get name of a temp directory which will be automatically cleaned up
tempdir = process.current_process()._config.get('tempdir')
Expand Down
33 changes: 33 additions & 0 deletions Lib/test/test_multiprocessing_forkserver/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,40 @@
import os
import re
import unittest
from test.support import os_helper
from multiprocessing.util import _SUN_PATH_MAX
from test._test_multiprocessing import install_tests_in_module_dict
from test.support import script_helper

install_tests_in_module_dict(globals(), 'forkserver', exclude_types=True)


class TestForkServerConfiguration(unittest.TestCase):
def test_respect_sun_path_max(self):
# Ensure that the calculation for temporary filepath lengths is correct.
# See https://github.com/python/cpython/issues/149527.

cmd = '''if 1:
from multiprocessing.connection import arbitrary_address
from multiprocessing.util import get_temp_dir
if __name__ == "__main__":
print(get_temp_dir())
print(arbitrary_address("AF_UNIX"))
'''
with os_helper.temp_dir() as root:
self.assertLess(len(root), _SUN_PATH_MAX)
_, out, _ = script_helper.assert_python_ok('-c', cmd, TMPDIR=root)
res = out.decode().strip().splitlines()
self.assertEqual(len(res), 2)

temp_pymp = res[0]
temp_pymp_regex = os.path.join(re.escape(root), r"pymp-\w{8}")
self.assertRegex(temp_pymp, temp_pymp_regex)

temp_sock = res[1]
temp_sock_regex = os.path.join(temp_pymp_regex, r"sock-[0-9a-fA-F]{12}")
self.assertRegex(temp_sock, temp_sock_regex)


if __name__ == '__main__':
unittest.main()
Loading