Skip to content

gh-149046: fix: correctly handle str subclasses in StringIO #149047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Jun 1, 2026
Merged

gh-149046: fix: correctly handle str subclasses in StringIO #149047

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd44100
fix: correctly handle str subclasses in StringIO
KowalskiThomas Apr 27, 2026
a854a57
test: add regression test
KowalskiThomas Apr 27, 2026
4f0649e
misc: add news entry
KowalskiThomas Apr 27, 2026
6b2a1e9
review: add comment before call
KowalskiThomas Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review: add comment before call
  • Loading branch information
@KowalskiThomas
KowalskiThomas committed Jun 1, 2026
commit 6b2a1e96e0e632bfa4c662c1f03355199d73f6c0
2 changes: 2 additions & 0 deletions Modules/_io/stringio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ write_str(stringio *self, PyObject *obj)

if (self->state == STATE_ACCUMULATING) {
if (self->string_size == self->pos) {
// gh-149046: Avoid PyUnicodeWriter_WriteStr() which calls str(obj)
// on str subclasses
if (_PyUnicodeWriter_WriteStr((_PyUnicodeWriter*)self->writer, decoded))
goto fail;
goto success;
Expand Down
Loading