Skip to content

gh-148871: extend and improve LOAD_COMMON_CONSTANT #148971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 12 commits into from
May 2, 2026
+362 −184
Merged

gh-148871: extend and improve LOAD_COMMON_CONSTANT #148971

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fe39cfb
gh-148871: extend and improve `LOAD_COMMON_CONSTANT`
NekoAsakura Apr 24, 2026
940932f
fix error
NekoAsakura Apr 24, 2026
bec065a
update `globals-to-fix.tsv`
NekoAsakura Apr 24, 2026
35592b1
address requested changes
NekoAsakura Apr 25, 2026
22595cd
Merge branch 'main' into gh-148871/load-common-constant
NekoAsakura Apr 26, 2026
926bd52
fixup
NekoAsakura Apr 26, 2026
f654c71
retrigger CI
NekoAsakura Apr 26, 2026
b4068b3
revert `any`/`all` static-ification
NekoAsakura May 1, 2026
ebd1c28
Merge branch 'main' into gh-148871/load-common-constant
NekoAsakura May 1, 2026
44dc084
fixup: revert `any`/`all` static-ification
NekoAsakura May 1, 2026
558a5ac
Merge branch 'main' into gh-148871/load-common-constant
NekoAsakura May 1, 2026
b017ae9
Merge branch 'main' into gh-148871/load-common-constant
NekoAsakura May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@NekoAsakura
NekoAsakura committed Apr 26, 2026
commit 926bd52c2ebdaed05eadde85aadf9a0b0de2d31d
1 change: 0 additions & 1 deletion Python/flowgraph.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,7 +1509,6 @@ instr_make_load_const(cfg_instr *instr, PyObject *newconst,
if (res > 0) {
return SUCCESS;
}
int oparg = add_const(newconst, consts, const_cache);
int oparg = add_const(newconst, consts, const_cache, consts_index);
RETURN_IF_ERROR(oparg);
INSTR_SET_OP1(instr, LOAD_CONST, oparg);
Expand Down
Loading