Skip to content

gh-148823: Avoid importing _colorize when creating an ArgumentParser #148827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 12 commits into from
May 6, 2026
Merged

gh-148823: Avoid importing _colorize when creating an ArgumentParser #148827

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a2c9395
Add test helper logic to allow for additional commands in lazy import…
DavidCEllis Apr 13, 2026
629dd53
add tests for lazy imports
DavidCEllis Apr 13, 2026
4fa408e
Lazily import _colorize
DavidCEllis Apr 13, 2026
dd8dcf9
subparser has also been fixed
DavidCEllis Apr 21, 2026
36743f6
Add a test for parse_args (based on the readme example)
DavidCEllis May 6, 2026
594619c
remove unnecessary f-string
DavidCEllis May 6, 2026
45ca6b4
📜🤖 Added by blurb_it.
blurb-it[bot] May 6, 2026
43b1c51
Merge remote-tracking branch 'upstream/main' into defer-colorize-argp…
DavidCEllis May 6, 2026
0740ca8
Don't use colour for validation checks to avoid the _colorize import
DavidCEllis May 6, 2026
da033fe
Add a test to make sure the fake 'colorless' theme stays in sync with
DavidCEllis May 6, 2026
c803a10
Include the comment from the suggestion
DavidCEllis May 6, 2026
1d13627
Merge branch 'main' into defer-colorize-argparse
savannahostrowski May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test helper logic to allow for additional commands in lazy import… 
… tests
  • Loading branch information
@DavidCEllis
DavidCEllis committed Apr 21, 2026
commit a2c939581de35e312aa1ed479be13abc64837eb4
12 changes: 11 additions & 1 deletion Lib/test/support/import_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def ready_to_import(name=None, source=""):
sys.modules.pop(name, None)


def ensure_lazy_imports(imported_module, modules_to_block):
def ensure_lazy_imports(imported_module, modules_to_block, *, additional_code=None):
"""Test that when imported_module is imported, none of the modules in
modules_to_block are imported as a side effect."""
modules_to_block = frozenset(modules_to_block)
Expand All @@ -343,6 +343,16 @@ def ensure_lazy_imports(imported_module, modules_to_block):
raise AssertionError(f'unexpectedly imported after importing {imported_module}: {{after}}')
"""
)
if additional_code:
script += additional_code
script += textwrap.dedent(
f"""
if unexpected := modules_to_block & sys.modules.keys():
after = ", ".join(unexpected)
raise AssertionError(f'unexpectedly imported after additional code: {{after}}')
"""
)

from .script_helper import assert_python_ok
assert_python_ok("-S", "-c", script)

Expand Down