Skip to content

gh-146636: Improve ABI/feature selection, add new header for it #148302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 11 commits into from
Apr 23, 2026
+148 −82
Merged

gh-146636: Improve ABI/feature selection, add new header for it #148302

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1116e1e
gh-146636: abi3t: Test that Python.h avoids checking Py_GIL_DISABLED
encukou Apr 5, 2026
4581298
Move ABI/feature selection macros to their own header
encukou Apr 9, 2026
e1b7500
Update check for <intrin.h>
encukou Apr 9, 2026
247bd46
Typo
encukou Apr 9, 2026
7835449
Move Py_BUILD_CORE undefines, and include exports.h directly from Pyt…
encukou Apr 9, 2026
2ad80d8
Comments
encukou Apr 9, 2026
7c9d920
Apply suggestions from code review
encukou Apr 10, 2026
38950b8
Merge in the main branch
encukou Apr 17, 2026
c477a14
Don't poison on clang
encukou Apr 17, 2026
05e7c90
Error out if _Py_OPAQUE_PYOBJECT is defined by user
encukou Apr 17, 2026
72b1637
Require version in Py_LIMITED_API & Py_TARGET_ABI3T
encukou Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-146636: abi3t: Test that Python.h avoids checking Py_GIL_DISABLED 
Add a test that Python headers themselves don't use
Py_GIL_DISABLED in abi3t: abi3 and abi3t ought to be the
same except the _Py_OPAQUE_PYOBJECT differences.
This is done using the GCC-only poison pragma.
  • Loading branch information
@encukou
encukou committed Apr 9, 2026
commit 1116e1ece97d7498c886d7a73ad4aa800d180eed
11 changes: 11 additions & 0 deletions Include/pyport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,17 @@
// locking needed in for free-threaded interpreters builds.
# define Py_GIL_DISABLED
# endif
# if defined(_Py_IS_TESTCEXT)
// When compiling for abi3t, contents of Python.h should not depend
// on Py_GIL_DISABLED.
// We ask GCC to error if it sees the macro from this point on.
// Since users are free to the macro, and there's no way to undo the poisoning
// at the end of Python.h, we only do this in a test module.
# ifdef __GNUC__
# undef Py_GIL_DISABLED
# pragma GCC poison Py_GIL_DISABLED
# endif
# endif
#endif


Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_cext/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
# The purpose of test_cext extension is to check that building a C
# extension using the Python C API does not emit C compiler warnings.
'-Werror',
# Enable extra checks for header files, which:
# - need to be enabled somewhere inside Python headers (rather than
# before including Python.h)
# - should not be checked for user code
'-D_Py_IS_TESTCEXT',
]

# C compiler flags for GCC and clang
Expand Down