Skip to content

gh-146640: Optimize int operations by mutating uniquely-referenced operands in place (JIT only) #146641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 15 commits into from
Apr 3, 2026
Merged

gh-146640: Optimize int operations by mutating uniquely-referenced operands in place (JIT only) #146641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
befeded
Add inplace binary operations for type int-int
eendebakpt Mar 30, 2026
964bb34
rework
eendebakpt Mar 30, 2026
f33b452
refactor
eendebakpt Mar 30, 2026
654ae93
fix tag assignment
eendebakpt Mar 30, 2026
af5b4c9
fix result refs
eendebakpt Mar 30, 2026
9d13a23
review comments
eendebakpt Mar 31, 2026
46b6cca
news entry
eendebakpt Mar 31, 2026
63c1317
fix
eendebakpt Mar 31, 2026
4d6288b
move dup into macro
eendebakpt Mar 31, 2026
73b9a45
Merge branch 'main' into int_int_inplace
eendebakpt Mar 31, 2026
3fb1e6c
Apply suggestion from @eendebakpt
eendebakpt Mar 31, 2026
7710226
revert
eendebakpt Mar 31, 2026
60b81be
review comments
eendebakpt Apr 1, 2026
e0bae62
Merge branch 'main' into int_int_inplace
eendebakpt Apr 1, 2026
76e0785
Apply suggestion from @eendebakpt
eendebakpt Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@eendebakpt
eendebakpt committed Mar 31, 2026
commit 63c1317c6b8f2c6f1c0c0e00a171fdb2223fe5b2
30 changes: 12 additions & 18 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,8 +713,6 @@ dummy_func(
// the following _POP_TOP_INT becomes _POP_TOP_NOP. Tier 2 only.
tier2 op(_BINARY_OP_ADD_INT_INPLACE, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, left, +, _PyCompactLong_Add);
r = right;
DEAD(right);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(left);
Expand All @@ -723,13 +721,12 @@ dummy_func(
res = _int_inplace_res;
}
l = left;
DEAD(left);
r = right;
INPUTS_DEAD();
}

tier2 op(_BINARY_OP_SUBTRACT_INT_INPLACE, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, left, -, _PyCompactLong_Subtract);
r = right;
DEAD(right);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(left);
Expand All @@ -738,13 +735,12 @@ dummy_func(
res = _int_inplace_res;
}
l = left;
DEAD(left);
r = right;
INPUTS_DEAD();
}

tier2 op(_BINARY_OP_MULTIPLY_INT_INPLACE, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, left, *, _PyCompactLong_Multiply);
r = right;
DEAD(right);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(left);
Expand All @@ -753,52 +749,50 @@ dummy_func(
res = _int_inplace_res;
}
l = left;
DEAD(left);
r = right;
INPUTS_DEAD();
}

tier2 op(_BINARY_OP_ADD_INT_INPLACE_RIGHT, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, right, +, _PyCompactLong_Add);
l = left;
DEAD(left);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(right);
}
else {
res = _int_inplace_res;
}
l = left;
r = right;
DEAD(right);
INPUTS_DEAD();
}

tier2 op(_BINARY_OP_SUBTRACT_INT_INPLACE_RIGHT, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, right, -, _PyCompactLong_Subtract);
l = left;
DEAD(left);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(right);
}
else {
res = _int_inplace_res;
}
l = left;
r = right;
DEAD(right);
INPUTS_DEAD();
}

tier2 op(_BINARY_OP_MULTIPLY_INT_INPLACE_RIGHT, (left, right -- res, l, r)) {
INT_INPLACE_OP(left, right, right, *, _PyCompactLong_Multiply);
l = left;
DEAD(left);
EXIT_IF(!_int_inplace_ok && PyStackRef_IsNull(_int_inplace_res));
if (_int_inplace_ok) {
res = PyStackRef_DUP(right);
}
else {
res = _int_inplace_res;
}
l = left;
r = right;
DEAD(right);
INPUTS_DEAD();
}

op(_GUARD_NOS_FLOAT, (left, unused -- left, unused)) {
Expand Down
Loading
Loading