Skip to content

gh-146615: Fix format specifiers in extension modules #146617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Mar 31, 2026
Merged

gh-146615: Fix format specifiers in extension modules #146617

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96fcf41
Fix format specifiers in error messages across multiple modules
sunmy2019 Mar 30, 2026
36774be
prefer another PR to fix
sunmy2019 Mar 30, 2026
f16838e
resolve comments
sunmy2019 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
resolve comments
  • Loading branch information
@sunmy2019
sunmy2019 committed Mar 30, 2026
commit f16838e332be43d73ff1a005ba1e261a9597ff95
12 changes: 4 additions & 8 deletions Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4016,15 +4016,11 @@ _ssl__SSLContext_verify_flags_set_impl(PySSLContext *self, PyObject *value)
static int
set_min_max_proto_version(PySSLContext *self, PyObject *arg, int what)
{
long v;
int v;
int result;

if (!PyArg_Parse(arg, "l", &v))
if (!PyArg_Parse(arg, "i", &v))
return -1;
if (v > INT_MAX) {
PyErr_SetString(PyExc_OverflowError, "Option is too long");
return -1;
}

switch(self->protocol) {
case PY_SSL_VERSION_TLS_CLIENT: _Py_FALLTHROUGH;
Expand Down Expand Up @@ -4059,7 +4055,7 @@ set_min_max_proto_version(PySSLContext *self, PyObject *arg, int what)
break;
default:
PyErr_Format(PyExc_ValueError,
"Unsupported TLS/SSL version 0x%lx", v);
"Unsupported TLS/SSL version 0x%x", (unsigned)v);
return -1;
}

Expand Down Expand Up @@ -4093,7 +4089,7 @@ set_min_max_proto_version(PySSLContext *self, PyObject *arg, int what)
}
if (result == 0) {
PyErr_Format(PyExc_ValueError,
"Unsupported protocol version 0x%lx", v);
"Unsupported protocol version 0x%x", (unsigned)v);
return -1;
}
return 0;
Expand Down
Loading