Skip to content

gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName #146356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Mar 25, 2026
Merged

gh-146355: Fix main_module ref leak in _PyRun_SimpleStringFlagsWithName #146356

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf1ef3
refactor _PyRun_SimpleStringFlagsWithName to follow goto pattern in _…
A0su Mar 24, 2026
4c99feb
change to single line fix adding main_module decref
A0su Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions Python/pythonrun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,32 +554,39 @@ PyRun_SimpleFileExFlags(FILE *fp, const char *filename, int closeit,

int
_PyRun_SimpleStringFlagsWithName(const char *command, const char* name, PyCompilerFlags *flags) {
int ret = -1;

PyObject *main_module = PyImport_AddModuleRef("__main__");
if (main_module == NULL) {
return -1;
return ret;
}
PyObject *dict = PyModule_GetDict(main_module); // borrowed ref

PyObject *the_name = NULL;
PyObject *res = NULL;
if (name == NULL) {
res = PyRun_StringFlags(command, Py_file_input, dict, dict, flags);
} else {
PyObject* the_name = PyUnicode_FromString(name);
if (!the_name) {
the_name = PyUnicode_FromString(name);
if (the_name == NULL) {
PyErr_Print();
return -1;
goto done;
}
res = _PyRun_StringFlagsWithName(command, the_name, Py_file_input, dict, dict, flags, 0);
Py_DECREF(the_name);
}
Py_DECREF(main_module);
if (res == NULL) {
PyErr_Print();
return -1;
goto done;
}

Py_DECREF(res);
return 0;
ret = 0;

done:
Py_DECREF(main_module);
Py_XDECREF(the_name);
Py_XDECREF(res);

return ret;
}

int
Expand Down
Loading