Skip to content

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version #146338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 5 commits into from
Apr 3, 2026
Merged

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version #146338

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
390cc8a
fix building the jit stencils on Windows when the
chris-eibl Mar 23, 2026
1a08565
Use Savannah's much better and shorter description
chris-eibl Apr 3, 2026
48eb2ea
Merge branch 'main' into gh146210
chris-eibl Apr 3, 2026
3c00136
env.pop("INCLUDE", None)
chris-eibl Apr 3, 2026
443bb06
Merge branch 'main' into gh146210
savannahostrowski Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
env.pop("INCLUDE", None)
  • Loading branch information
@chris-eibl
chris-eibl committed Apr 3, 2026
commit 3c001368b0c1d853fc47c2b4f17f887c121a93c7
13 changes: 5 additions & 8 deletions Tools/jit/_llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,12 @@ async def _run(tool: str, args: typing.Iterable[str], echo: bool = False) -> str
print(shlex.join(command))

if os.name == "nt":
# When building with /p:PlatformToolset=ClangCL, the VS build
# system puts that clang's include path into INCLUDE. The JIT's
# clang may be a different version, and mismatched headers cause
# build errors. See https://github.com/python/cpython/issues/146210.
env = os.environ.copy()
Comment thread
chris-eibl marked this conversation as resolved.
try:
# When building with /p:PlatformToolset=ClangCL, the VS build
# system puts that clang's include path into INCLUDE. The JIT's
# clang may be a different version, and mismatched headers cause
# build errors. See https://github.com/python/cpython/issues/146210
del env["INCLUDE"]
except KeyError:
pass
env.pop("INCLUDE", None)
else:
env = None
try:
Expand Down
Loading