Skip to content

gh-146245: Fix reference and buffer leaks via audit hook in socket module #146248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 7 commits into from
Mar 22, 2026
Merged

gh-146245: Fix reference and buffer leaks via audit hook in socket module #146248

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bef84d6
Fix reference and buffer leaks audit hook in socket module
aisk Mar 21, 2026
8c837e7
Add tests for socket audit hook leak
aisk Mar 21, 2026
27f2e2f
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 21, 2026
1321d47
Fix news entry
aisk Mar 21, 2026
026d272
Utilize assertAlmostEqual with delta in tests
aisk Mar 21, 2026
396b8c6
Simplify the codes
aisk Mar 21, 2026
6e079ab
Revert the tests
aisk Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert the tests
  • Loading branch information
@aisk
aisk committed Mar 21, 2026
commit 6e079ab5d4e38b319f696c5c57cd0ab3f94f9c5a
62 changes: 1 addition & 61 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from unittest import mock
from test import support
from test.support import (
cpython_only, is_apple, os_helper, refleak_helper, script_helper, socket_helper, threading_helper
cpython_only, is_apple, os_helper, refleak_helper, socket_helper, threading_helper
)
from test.support.import_helper import ensure_lazy_imports
import _thread as thread
Expand All @@ -28,7 +28,6 @@
import struct
import sys
import tempfile
import textwrap
import threading
import time
import traceback
Expand Down Expand Up @@ -7499,65 +7498,6 @@ def close_fds(fds):
self.assertEqual(data, str(index).encode())


@support.requires_subprocess()
@unittest.skipUnless(hasattr(sys, "gettotalrefcount"),
"requires sys.gettotalrefcount()")
class AuditHookLeakTests(unittest.TestCase):
# gh-146245: Reference and buffer leaks in audit hook failure paths.

def test_getaddrinfo_audit_hook_leak(self):
code = textwrap.dedent("""
import socket
import sys
import gc

def hook(*args):
raise ValueError("audit")

sys.addaudithook(hook)
gc.collect()
before = sys.gettotalrefcount()
for _ in range(100):
try:
socket.getaddrinfo(None, 80)
except ValueError:
pass
gc.collect()
after = sys.gettotalrefcount()
print(after - before)
""")
rc, out, err = script_helper.assert_python_ok("-c", code)
leaked = int(out.strip())
self.assertAlmostEqual(leaked, 0, delta=2, msg=f"Leaked {leaked} references")

def test_sendto_audit_hook_leak(self):
code = textwrap.dedent("""
import socket
import sys
import gc

def hook(*args):
raise ValueError("audit")

s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
sys.addaudithook(hook)
gc.collect()
before = sys.gettotalrefcount()
for _ in range(100):
try:
s.sendto(bytearray(b"x"), ("127.0.0.1", 80))
except ValueError:
pass
gc.collect()
after = sys.gettotalrefcount()
s.close()
print(after - before)
""")
rc, out, err = script_helper.assert_python_ok("-c", code)
leaked = int(out.strip())
self.assertAlmostEqual(leaked, 0, delta=2, msg=f"Leaked {leaked} references")


class FreeThreadingTests(unittest.TestCase):

def test_close_detach_race(self):
Expand Down
Loading