Skip to content

gh-146211: Reject CR/LF in HTTP tunnel request headers #146212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 6 commits into from
Apr 10, 2026
Merged

gh-146211: Reject CR/LF in HTTP tunnel request headers #146212

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1703bdd
gh-146211: Reject CR/LF in HTTP tunnel request headers
sethmlarson Mar 20, 2026
fc69621
Merge branch 'main' into http-client-proxy-tunnel
sethmlarson Mar 20, 2026
277163d
Update Lib/http/client.py
sethmlarson Apr 10, 2026
0d50065
Merge branch 'main' into http-client-proxy-tunnel
sethmlarson Apr 10, 2026
b7ea6ae
Escape single quote
sethmlarson Apr 10, 2026
0176ee7
Update test_httplib.py
sethmlarson Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/http/client.py 
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
  • Loading branch information
@sethmlarson @illia-v
sethmlarson and illia-v authored Apr 10, 2026
commit 277163d3cee1ef360eda1dac94294fba56417fef
3 changes: 2 additions & 1 deletion Lib/http/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,8 @@ def _wrap_ipv6(self, ip):

def _tunnel(self):
if _contains_disallowed_url_pchar_re.search(self._tunnel_host):
raise ValueError('Invalid header value %r' % (self._tunnel_host,))
raise ValueError('Tunnel host can't contain control characters %r'
% (self._tunnel_host,))
connect = b"CONNECT %s:%d %s\r\n" % (
self._wrap_ipv6(self._tunnel_host.encode("idna")),
self._tunnel_port,
Expand Down
Loading