Skip to content

gh-146044: Fix ctrl-w (unix-word-rubout) to use whitespace word boundaries #146174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimimgo wants to merge 8 commits into
base: main
Choose a base branch
from
+56 −1
Open

gh-146044: Fix ctrl-w (unix-word-rubout) to use whitespace word boundaries #146174

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
678eefd
Fix ctrl-w (unix-word-rubout) to use whitespace word boundaries (#146…
kimimgo Mar 19, 2026
853cb8c
Fix test: prepare_console() requires events argument
kimimgo Mar 19, 2026
99023b2
Add NEWS entry for gh-146044
kimimgo Mar 19, 2026
e6d27d9
Address review: rename bow_ws, move tests to TestReader, add tab support
kimimgo Mar 21, 2026
9f54090
Fix trailing blank lines in test_reader.py
kimimgo Mar 21, 2026
140faf1
Address review: close docstring on separate line
kimimgo Mar 22, 2026
c8d1759
Address review: remove issue URL from docstring, add newline test
kimimgo Mar 27, 2026
0a25f0b
Address review: use index() instead of magic number for pos
kimimgo Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test: prepare_console() requires events argument
  • Loading branch information
@kimimgo
kimimgo committed Mar 19, 2026
commit 853cb8ca3e293b2d6e8373eeab2887505984e95b
8 changes: 4 additions & 4 deletions Lib/test/test_pyrepl/test_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ def test_bow_whitespace_stops_at_whitespace(self):
# GH#146044

@picnixz picnixz Mar 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        # See https://github.com/cpython/issues/146044

Use a link looking like that so that I can click on it in my IDE. I created the link from memory sonjust check that it is the correct URL.

# unix-word-rubout (ctrl-w) should use whitespace boundaries,
# not punctuation boundaries like bow() does
reader = prepare_reader(prepare_console())
reader = prepare_reader(prepare_console([]))
reader.buffer = list("foo.bar baz")
reader.pos = len(reader.buffer) # cursor at end

Expand All @@ -575,7 +575,7 @@ def test_bow_whitespace_stops_at_whitespace(self):

def test_bow_whitespace_includes_punctuation_in_word(self):
# GH#146044
reader = prepare_reader(prepare_console())
reader = prepare_reader(prepare_console([]))
reader.buffer = list("foo.bar(baz) qux")
reader.pos = 12 # cursor after ")"

Expand All @@ -585,7 +585,7 @@ def test_bow_whitespace_includes_punctuation_in_word(self):

def test_bow_stops_at_punctuation(self):
# Verify existing bow() still uses syntax_table (punctuation boundary)
reader = prepare_reader(prepare_console())
reader = prepare_reader(prepare_console([]))
reader.buffer = list("foo.bar baz")
reader.pos = len(reader.buffer)

Expand All @@ -594,7 +594,7 @@ def test_bow_stops_at_punctuation(self):

def test_bow_vs_bow_whitespace_difference(self):
# The key difference: bow() stops at '.', bow_whitespace() does not
reader = prepare_reader(prepare_console())
reader = prepare_reader(prepare_console([]))
reader.buffer = list("foo.bar")
reader.pos = len(reader.buffer)

Expand Down
Loading