Skip to content

gh-146121: pkgutil.get_data() reject invalid resource arguments #146122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 4 commits into from
Mar 18, 2026
Merged

gh-146121: pkgutil.get_data() reject invalid resource arguments #146122

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b6e6a4
`pkgutil.get_data()` reject invalid resource arguments
StanFromIreland Mar 16, 2026
f3c66b9
Update news entry
StanFromIreland Mar 18, 2026
531e7c3
Fix test on windows, use `os.sep`
StanFromIreland Mar 18, 2026
7d4d601
Use `os.path.abspath` instead
StanFromIreland Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
pkgutil.get_data() reject invalid resource arguments
  • Loading branch information
@StanFromIreland
StanFromIreland committed Mar 16, 2026
commit 9b6e6a4b8469ead1bbd546d723de49fcaa83e798
3 changes: 3 additions & 0 deletions Lib/pkgutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,9 @@ def get_data(package, resource):
# signature - an os.path format "filename" starting with the dirname of
# the package's __file__
parts = resource.split('/')
if os.path.isabs(resource) or '..' in parts:
raise ValueError("resource must be a relative path with no "
"parent directory components")
parts.insert(0, os.path.dirname(mod.__file__))
resource_name = os.path.join(*parts)
return loader.get_data(resource_name)
Expand Down
19 changes: 19 additions & 0 deletions Lib/test/test_pkgutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,25 @@ def test_getdata_filesys(self):

del sys.modules[pkg]

def test_getdata_path_traversal(self):
pkg = 'test_getdata_traversal'

# Make a package with some resources
package_dir = os.path.join(self.dirname, pkg)
os.mkdir(package_dir)
# Empty init.py
f = open(os.path.join(package_dir, '__init__.py'), "wb")
f.close()

with self.assertRaises(ValueError):
pkgutil.get_data(pkg, '../../../etc/passwd')
with self.assertRaises(ValueError):
pkgutil.get_data(pkg, 'sub/../../../etc/passwd')
with self.assertRaises(ValueError):
pkgutil.get_data(pkg, '/etc/passwd')
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated

del sys.modules[pkg]

def test_getdata_zipfile(self):
zip = 'test_getdata_zipfile.zip'
pkg = 'test_getdata_zipfile'
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-03-16-18-07-00.gh-issue-111111.vRbdro.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:func:`pkgutil.get_data` now raises rejects *resource* arguments containing the
parent directory components or that is an absolute path.
This addresses :cve:`2026-3479`.