Skip to content

[3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode #146119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Mar 19, 2026
Merged

[3.14] gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode #146119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bd1e9d
gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode
vstinner Mar 18, 2026
659c4ed
Fix also _BINARY_OP_INPLACE_ADD_UNICODE opcode
vstinner Mar 18, 2026
3517db6
Fix reference counting
vstinner Mar 18, 2026
83d5ef3
Replace ERROR_IF(1) with ERROR_IF(true)
vstinner Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-146092: Fix error handling in _BINARY_OP_ADD_FLOAT opcode 
Fix error handling in _PyFloat_FromDouble_ConsumeInputs() used by
_BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT and
_BINARY_OP_MULTIPLY_FLOAT opcodes. PyStackRef_FromPyObjectSteal()
must not be called with a NULL pointer.
  • Loading branch information
@vstinner
vstinner committed Mar 18, 2026
commit 3bd1e9db2ae21cfc12e417b461f44d4cfc50cb89
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-03-18-16-57-56.gh-issue-146092.wCKFYS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Handle properly memory allocation failures on float operations in the
bytecode opcodes. Patch by Victor Stinner.
6 changes: 5 additions & 1 deletion Objects/floatobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ _PyStackRef _PyFloat_FromDouble_ConsumeInputs(_PyStackRef left, _PyStackRef righ
{
PyStackRef_CLOSE_SPECIALIZED(left, _PyFloat_ExactDealloc);
PyStackRef_CLOSE_SPECIALIZED(right, _PyFloat_ExactDealloc);
return PyStackRef_FromPyObjectSteal(PyFloat_FromDouble(value));
PyObject *obj = PyFloat_FromDouble(value);
if (obj == NULL) {
return PyStackRef_NULL;
}
return PyStackRef_FromPyObjectSteal(obj);
}

static PyObject *
Expand Down
Loading