Skip to content

gh-135953: Properly obtain main thread identifier in Gecko Collector #146045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Mar 22, 2026
Merged

gh-135953: Properly obtain main thread identifier in Gecko Collector #146045

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a82ac9
profiling(Gecko): Properly obtain main thread identifier
flowln Mar 17, 2026
8920f2f
profiling(gecko): take last thread as main thread instead of first one
flowln Mar 17, 2026
d9b0a79
profiling(Gecko): check if thread list is not empty before accessing it
flowln Mar 17, 2026
f186d3f
profiling(gecko): retrieve main thread id directly from interpreter s…
flowln Mar 21, 2026
5849aad
profiling(gecko): add main_thread_id to MockInterpreter and add check…
flowln Mar 21, 2026
ad5b78c
profiling(gecko): use status flag for main thread instead of Interpre…
pablogsal Mar 22, 2026
acbbd15
Add news entry
pablogsal Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
profiling(gecko): take last thread as main thread instead of first one 
The ordering is actually newest -> oldest, since the _remote_debugging
code traverses the ThreadState linked list in the intepreter state, appending
to a list of threads in-order.

Signed-off-by: Sofia Donato Ferreira <flowlnlnln@gmail.com>
  • Loading branch information
@flowln
flowln committed Mar 17, 2026
commit 8920f2f062bf3c93090c5ed2d1fab079baa6645f
8 changes: 3 additions & 5 deletions Lib/profiling/sampling/gecko_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,16 @@ def collect(self, stack_frames, timestamps_us=None):
self.last_sample_time = times[-1]

# Process threads
main_tid = None
for interpreter_info in stack_frames:
# Since 'threads' is in order from newest to oldest,
# we know the first thread must be the main thread.
main_tid = interpreter_info.threads[-1].thread_id
for thread_info in interpreter_info.threads:
frames = filter_internal_frames(thread_info.frame_info)
tid = thread_info.thread_id

# Initialize thread if needed
if tid not in self.threads:
# Since 'threads' is in order from oldest to newest,
# we know the first thread must be the main thread.
if len(self.threads) == 0:
main_tid = tid
self.threads[tid] = self._create_thread(tid, main_tid)

thread_data = self.threads[tid]
Expand Down
Loading