Skip to content

gh-145376: Fix GC tracking in structseq.__replace__ #145820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 8 commits into from
Mar 13, 2026
Merged

gh-145376: Fix GC tracking in structseq.__replace__ #145820

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d279067
Fix bug in tracking of structseq
eendebakpt Mar 11, 2026
bf01d4c
add test
eendebakpt Mar 11, 2026
0d3d149
pep8
eendebakpt Mar 11, 2026
0b54103
pep8
eendebakpt Mar 11, 2026
c6040c6
Merge branch 'structseq_tracking' of github.com:eendebakpt/cpython in…
eendebakpt Mar 11, 2026
3bd205f
revert unrelated changes
eendebakpt Mar 11, 2026
2e04864
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 11, 2026
d786df3
Update Misc/NEWS.d/next/Core_and_Builtins/2026-03-11-21-27-28.gh-issu…
eendebakpt Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@eendebakpt
eendebakpt committed Mar 11, 2026
commit bf01d4c3cff8edb857fe2218075d1e789d9ae077
9 changes: 9 additions & 0 deletions Lib/test/test_structseq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import copy
import gc
import os
import pickle
import re
Expand Down Expand Up @@ -355,6 +356,14 @@ def test_reference_cycle(self):
type(t).refcyle = t
"""))

def test_replace_gc_tracked(self):
# Verify that __replace__ results are properly GC-tracked
time_struct= time.gmtime(0)
lst = []
replaced_struct = time_struct.__replace__(tm_year=lst)
lst.append(replaced_struct)

self.assertTrue(gc.is_tracked(replaced_struct))

if __name__ == "__main__":
unittest.main()