Skip to content

gh-141510: Always return a dict in PyDict_Copy() #145517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 4 commits into from
Closed

gh-141510: Always return a dict in PyDict_Copy() #145517

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cbef89
gh-141510: Always return a dict in PyDict_Copy()
vstinner Mar 4, 2026
3662ec8
Run make clinic
vstinner Mar 4, 2026
91e9506
Add more tests
vstinner Mar 4, 2026
de6b0b7
Complete PyDict_Copy() documentation
vstinner Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more tests
  • Loading branch information
@vstinner
vstinner committed Mar 4, 2026
commit 91e9506df7c80f54aee4f053a3306e5c4633c2d6
8 changes: 8 additions & 0 deletions Lib/test/test_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1848,11 +1848,19 @@ def test_merge(self):
frozendict({'x': 1, 'y': 2}))
self.assertEqual(frozendict(x=1, y=2) | frozendict(y=5),
frozendict({'x': 1, 'y': 5}))
self.assertEqual(FrozenDict(x=1, y=2) | FrozenDict(y=5),
frozendict({'x': 1, 'y': 5}))

fd = frozendict(x=1, y=2)
self.assertIs(fd | frozendict(), fd)
self.assertIs(fd | {}, fd)
self.assertIs(frozendict() | fd, fd)

fd = FrozenDict(x=1, y=2)
self.assertEqual(fd | frozendict(), fd)
self.assertEqual(fd | {}, fd)
self.assertEqual(frozendict() | fd, fd)

def test_update(self):
# test "a |= b" operator
d = frozendict(x=1)
Expand Down
Loading