Skip to content

gh-145376: Fix refleak and null pointer deref in unusual error path of datetime module #145476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 5 commits into from
Mar 5, 2026
Merged

gh-145376: Fix refleak and null pointer deref in unusual error path of datetime module #145476

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01f9398
Fix refleak and null pointer deref in datetimemodule
eendebakpt Mar 3, 2026
5673c7e
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 3, 2026
13a6835
Merge branch 'main' into refleak_datetime
eendebakpt Mar 3, 2026
eed626d
Update Modules/_datetimemodule.c
eendebakpt Mar 5, 2026
7dac494
remove news entry
eendebakpt Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] authored Mar 3, 2026
commit 5673c7eb2096ed23a470e0f6882c63b946b7e8c6
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-03-03-19-42-51.gh-issue-145376.T7nY3q.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix refleak and null pointer deref in unusual error path of :mod:`datetime`.

@vstinner vstinner Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it, users should not be impacted by this change. The error case is very unlikely.

@StanFromIreland StanFromIreland Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested adding it since this PR covers several cases increasing the likelyhood of one of them being hit. If you think it is better to remove it, I don't mind.

@vstinner vstinner Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we don't document such fix for an unlikely corner case.

PyLong_FromLong() can only fail if the system has no more free memory.

datetime.datetime.astimezone() reads freed memory, but it only occurs if utcoffset() returns the wrong type. It seems like nobody reported the issue (with a reproducer), so it sounds unlikely to crash in practice (reading freed memory just works in the common case).

Loading