Skip to content

GH-145247: Implement _PyTuple_FromPair #145325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 20 commits into from
Mar 10, 2026
Merged

GH-145247: Implement _PyTuple_FromPair #145325

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f2d3ab8
Add initial version of _PyTuple_FromPair
sergey-miryanov Feb 27, 2026
8459769
Add initial tests for _PyTuple_FromPair
sergey-miryanov Feb 27, 2026
b51ffc6
Fix warnings
sergey-miryanov Feb 27, 2026
b6c8727
Simplify tests
sergey-miryanov Feb 28, 2026
9408400
Remove unnecessary assert
sergey-miryanov Feb 28, 2026
5862613
Update Lib/test/test_capi/test_tuple.py
sergey-miryanov Mar 1, 2026
f5ad4df
Small fix - use items
sergey-miryanov Mar 5, 2026
1764785
Apply suggestions from code review
sergey-miryanov Mar 5, 2026
63a3c4b
Address review
sergey-miryanov Mar 5, 2026
67bd5fc
Apply suggestions from code review
sergey-miryanov Mar 6, 2026
53dad5b
Update Objects/tupleobject.c
sergey-miryanov Mar 7, 2026
9d28667
Address review
sergey-miryanov Mar 7, 2026
b0a5ede
Fix typo
sergey-miryanov Mar 7, 2026
e33a225
Address review
sergey-miryanov Mar 7, 2026
4c8c51d
Remove tuple_alloc_2
sergey-miryanov Mar 9, 2026
0711d3a
Merge branch 'main' into 145247-pytuple-from-pair
sergey-miryanov Mar 9, 2026
d05c9ef
Revert "GH-145278: freeze encodings (partially) and linecache (#145279)"
sergey-miryanov Mar 9, 2026
9fd4cff
Reapply "GH-145278: freeze encodings (partially) and linecache (#1452…
sergey-miryanov Mar 9, 2026
ba64a3e
Merge branch 'main' into 145247-pytuple-from-pair
sergey-miryanov Mar 9, 2026
e061960
Merge branch 'main' into 145247-pytuple-from-pair
sergey-miryanov Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
  • Loading branch information
@sergey-miryanov @johnslavik
sergey-miryanov and johnslavik authored Mar 6, 2026
commit 67bd5fc7bd75f082837c277770b384f386264afd
8 changes: 4 additions & 4 deletions Objects/tupleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ tuple_alloc_2(void)
PyObject *
_PyTuple_FromPair(PyObject *one, PyObject *two)
Comment thread
sergey-miryanov marked this conversation as resolved.
Outdated
{
assert (one != NULL);
assert (two != NULL);
assert(one != NULL);
assert(two != NULL);

PyTupleObject *op = tuple_alloc_2();
if (op == NULL) {
Expand All @@ -240,8 +240,8 @@ _PyTuple_FromPair(PyObject *one, PyObject *two)
PyObject *
_PyTuple_FromPairSteal(PyObject *one, PyObject *two)
Comment thread
sergey-miryanov marked this conversation as resolved.
Outdated
{
assert (one != NULL);
assert (two != NULL);
assert(one != NULL);
assert(two != NULL);

PyTupleObject *op = tuple_alloc_2();
if (op == NULL) {
Expand Down
Loading