Skip to content

GH-145273: warn when we can't find the standard library #145274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 12 commits into from
Mar 2, 2026
Merged

GH-145273: warn when we can't find the standard library #145274

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
08846b2
GH-145273: warn when we can't find the standard library
FFY00 Feb 26, 2026
d38285d
Fix test_embed
FFY00 Feb 26, 2026
c55803d
Create stdlib dir on test_init_pybuilddir{,_win32}
FFY00 Feb 26, 2026
3a67467
Resolve symlinks before file check (needed for Windows)
FFY00 Feb 26, 2026
aa6014a
Revert "Resolve symlinks before file check (needed for Windows)"
FFY00 Feb 27, 2026
540d965
Fix test.support.PythonSymlink on Windows source builds
FFY00 Feb 27, 2026
9cb1166
Fix test_embed by creating expected paths instead of ignoring stderr
FFY00 Feb 27, 2026
d8b5280
Don't blindly create paths
FFY00 Feb 28, 2026
36e43a7
Fix test_init_is_python_build_with_home
FFY00 Feb 28, 2026
8d63f14
Fix test_init_setpythonhome
FFY00 Feb 28, 2026
e69cddb
Don't create VPATH subdirs
FFY00 Mar 2, 2026
460501d
Create stdlibdir in test_init_pybuilddir_win32
FFY00 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Resolve symlinks before file check (needed for Windows)" 
This reverts commit 3a67467.

Signed-off-by: Filipe Laíns <lains@riseup.net>
  • Loading branch information
@FFY00
FFY00 committed Feb 27, 2026
commit aa6014ac56fd5906983d599864e3b9134cfc6a2e
6 changes: 3 additions & 3 deletions Modules/getpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,12 +774,12 @@ def search_up(prefix, *landmarks, test=isfile):
# ******************************************************************************

# Warn if the standard library is missing
if not stdlib_zip or not isfile(realpath(stdlib_zip)):
if not stdlib_zip or not isfile(stdlib_zip):
home_hint = f"The Python 'home' directory was set to {home!r}, is this correct?"
if not stdlib_dir or not isdir(realpath(stdlib_dir)):
if not stdlib_dir or not isdir(stdlib_dir):
hint = home_hint if home else f'sys.prefix is set to {prefix}, is this correct?'
warn('WARN: Could not find the standard library directory! ' + hint)
elif (not platstdlib_dir and not build_prefix) or not isdir(realpath(platstdlib_dir)):
elif (not platstdlib_dir and not build_prefix) or not isdir(platstdlib_dir):

@FFY00 FFY00 Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the tests, but unless we skip the platstdlib_dir check when running from source, the warning will show up on make, during the pybuilddir.txt generation.

I would prefer to drop the build_prefix check, and instead add -X pathconfig_warnings=0 to the -m sysconfig --generate-posix-vars call in the makefile.

Suggested change
elif (not platstdlib_dir and not build_prefix) or not isdir(platstdlib_dir):
elif not platstdlib_dir or not isdir(platstdlib_dir):

hint = home_hint if home else f'sys.exec_prefix is set to {exec_prefix}, is this correct?'
warn('WARN: Could not find the platform standard library directory! ' + hint)

Expand Down
Loading