Skip to content

gh-145056: Let dict specific tests accept frozendict as well #145060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhettinger wants to merge 3 commits into from
Closed

gh-145056: Let dict specific tests accept frozendict as well #145060

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f27f128
gh-145056: Let dict specific tests accept frozendict as well
rhettinger Feb 21, 2026
4d02992
Add tests
rhettinger Feb 21, 2026
a887273
Expand the fast path in the C version of OrderedDict
rhettinger Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests
  • Loading branch information
@rhettinger
rhettinger committed Feb 21, 2026
commit 4d02992b6ddf376de63f35e8826dbe9ea85748b4
2 changes: 2 additions & 0 deletions Lib/test/test_ordered_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ def test_merge_operator(self):
d |= list(b.items())
expected = OrderedDict({0: 0, 1: 1, 2: 2, 3: 3})
self.assertEqual(a | dict(b), expected)
self.assertEqual(a | frozendict(b), expected)

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not the type of the result to be tested too?

@rhettinger rhettinger Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing test didn't check result type. I don't want to feature creep this edit. Reviewing and expanding the existing test strategies can be a task for another day.

@serhiy-storchaka serhiy-storchaka Feb 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests are passed with unmodified code. Therefore they are not correct tests for this change.

self.assertEqual(a | b, expected)
self.assertEqual(c, expected)
self.assertEqual(d, expected)
Expand All @@ -706,6 +707,7 @@ def test_merge_operator(self):
c |= a
expected = OrderedDict({1: 1, 2: 1, 3: 3, 0: 0})
self.assertEqual(dict(b) | a, expected)
self.assertEqual(frozendict(b) | a, expected)
self.assertEqual(b | a, expected)
self.assertEqual(c, expected)

Expand Down
Loading