Skip to content

Refactor dict tuple opt #144530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rashes2006 wants to merge 2 commits into from
Closed

Refactor dict tuple opt #144530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174a82b
gh-140009: Optimize dict object by replacing PyTuple_Pack with PyTupl…
rashes2006 Feb 5, 2026
df80780
Restart CI tests after PR title update
rashes2006 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-140009: Optimize dict object by replacing PyTuple_Pack with PyTupl… 
…e_FromArray
  • Loading branch information
@rashes2006
rashes2006 committed Feb 5, 2026
commit 174a82b575f91ec17d879707b33f4c62d8be8905
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-02-06-03-40-59.gh-issue-140009.a1b2c3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve performance of dict object by replacing PyTuple_Pack with PyTuple_FromArray for small tuples.
6 changes: 4 additions & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5083,7 +5083,8 @@ dictiter_new(PyDictObject *dict, PyTypeObject *itertype)
}
if (itertype == &PyDictIterItem_Type ||
itertype == &PyDictRevIterItem_Type) {
di->di_result = PyTuple_Pack(2, Py_None, Py_None);
PyObject *items[] = {Py_None, Py_None};
di->di_result = PyTuple_FromArray(items, 2);
if (di->di_result == NULL) {
Py_DECREF(di);
return NULL;
Expand Down Expand Up @@ -6284,7 +6285,8 @@ dictitems_xor_lock_held(PyObject *d1, PyObject *d2)
}
}
else {
PyObject *pair = PyTuple_Pack(2, key, val2);
PyObject *items[] = {key, val2};
PyObject *pair = PyTuple_FromArray(items, 2);
if (pair == NULL) {
goto error;
}
Expand Down
Loading