Skip to content

gh-140009: Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray #144529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rashes2006 wants to merge 6 commits into from
Closed

gh-140009: Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray #144529

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b94bc71
Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray
Feb 5, 2026
79df6b1
Merge branch 'main' into refactor-dict-tuple-opt
rashes2006 Feb 5, 2026
da299f7
Add NEWS entry for gh-140009
Feb 5, 2026
587554a
Restart CI tests
Feb 5, 2026
813c438
Restart CI tests (take 2)
Feb 5, 2026
b699ea2
Restart CI tests (take 3)
Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray
  • Loading branch information
rashestripathy
rashestripathy committed Feb 5, 2026
commit b94bc717067f55d322ab510255ea7ce1b384e862
6 changes: 4 additions & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5083,7 +5083,8 @@ dictiter_new(PyDictObject *dict, PyTypeObject *itertype)
}
if (itertype == &PyDictIterItem_Type ||
itertype == &PyDictRevIterItem_Type) {
di->di_result = PyTuple_Pack(2, Py_None, Py_None);
PyObject *items[] = {Py_None, Py_None};
di->di_result = PyTuple_FromArray(items, 2);
if (di->di_result == NULL) {
Py_DECREF(di);
return NULL;
Expand Down Expand Up @@ -6284,7 +6285,8 @@ dictitems_xor_lock_held(PyObject *d1, PyObject *d2)
}
}
else {
PyObject *pair = PyTuple_Pack(2, key, val2);
PyObject *items[] = {key, val2};
PyObject *pair = PyTuple_FromArray(items, 2);
if (pair == NULL) {
goto error;
}
Expand Down
Loading