Skip to content

gh-140550: allow slots that repeat information from PyModuleDef #144340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 4 commits into from
Feb 9, 2026
Merged

gh-140550: allow slots that repeat information from PyModuleDef #144340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48ab83f
gh-140550: allow slots that repeat information from PyModuleDef
encukou Jan 30, 2026
247f1b4
Apply suggestions from GH UI
encukou Feb 2, 2026
52e6de9
Merge in the main branch
encukou Feb 3, 2026
db5a64e
Ensure the same pointer for strings
encukou Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from GH UI
  • Loading branch information
@encukou
encukou authored Feb 2, 2026
commit 247f1b4927610b7cca379c536d30a70e53efcf95
2 changes: 1 addition & 1 deletion Doc/c-api/module.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ remove it.

If the array contains slots corresponding to :c:type:`PyModuleDef`
members, the values must match.
For example, if you use :c:macro:`Py_mod_name` in :c:member:`!m_slots`;
For example, if you use :c:macro:`Py_mod_name` in :c:member:`!m_slots`,
:c:member:`PyModuleDef.m_name` must be set to the same pointer
(not just an equal string).
Comment thread
encukou marked this conversation as resolved.

Expand Down
2 changes: 1 addition & 1 deletion Objects/moduleobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ module_from_def_and_spec(
#undef DEF_SLOT_CASE
#undef COPY_DEF_SLOT
#undef COPY_NONDEF_SLOT
#undef _COPY_COMMON_SLOT
#undef COPY_NONNULL_SLOT
}

#ifdef Py_GIL_DISABLED
Expand Down
Loading