Skip to content

gh-144285: Improve AttributeError attribute suggestions #144299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 21 commits into from
Feb 12, 2026
Merged

gh-144285: Improve AttributeError attribute suggestions #144299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
726189c
Use "instead of" technique for clearer name suggestions
johnslavik Jan 28, 2026
600ede5
Prepend with a dot for better understanding
johnslavik Feb 7, 2026
89242f3
Don't change `NameError` messages
johnslavik Feb 7, 2026
32aa69d
Merge branch 'main' into feat-clearer-name-suggestions
johnslavik Feb 7, 2026
5ab2311
Bring back the TOCTOU for readability
johnslavik Feb 7, 2026
03b1f45
Remove `:` in `AttributeError` path
johnslavik Feb 7, 2026
d0f68a0
Don't prepend with dots in non-ASCII case
johnslavik Feb 7, 2026
fce7867
Fix typo
johnslavik Feb 7, 2026
6dc6612
Update tests
johnslavik Feb 7, 2026
79539b0
Add news entry
johnslavik Feb 7, 2026
6054352
Less words, more meaning
johnslavik Feb 7, 2026
f80d3da
Fix more tests
johnslavik Feb 7, 2026
c973a52
Handle non-ASCII cases correctly
johnslavik Feb 7, 2026
01337cf
Extend the normalized suggestions test
johnslavik Feb 7, 2026
97e075b
Make the extended test more strict
johnslavik Feb 7, 2026
107e7c0
Update news entry to reflect what happened
johnslavik Feb 7, 2026
57f08a6
Fix wording
johnslavik Feb 7, 2026
5bfdc3e
Final plumbing
johnslavik Feb 7, 2026
5e14b5f
Make the news entry easier
johnslavik Feb 7, 2026
b253b1c
Remove unneeded comment (code is self-explanatory)
johnslavik Feb 7, 2026
5a25fea
Fix colon usage inconsistency
johnslavik Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix more tests
  • Loading branch information
@johnslavik
johnslavik committed Feb 7, 2026
commit f80d3da474dd1e9836b96f54539645e55750f19c
2 changes: 1 addition & 1 deletion Lib/idlelib/idle_test/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def __eq__(self, other):
"Or did you forget to import 'abc'?\n"),
('int.reel', AttributeError,
"type object 'int' has no attribute 'reel'. "
"Did you mean: 'real'?\n"),
"Did you mean '.real' instead of '.reel'?\n"),
)

@force_not_colorized
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4375,7 +4375,7 @@ def __init__(self):

# Should suggest 'inner.data'
actual = self.get_suggestion(Outer(), 'data')
self.assertIn("Did you mean '.inner.data' instead of '.value'", actual)
self.assertIn("Did you mean '.inner.data' instead of '.data'", actual)

def test_getattr_nested_prioritizes_direct_matches(self):
# Test that direct attribute matches are prioritized over nested ones
Expand Down
Loading