Skip to content

gh-143959 Make _datetime,_types optional for test_types #144042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-143959 Make _datetime,_types optional for test_types #144042

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3b9317
gh-143959 Make _datetime optional for test_types
youknowone Jan 19, 2026
e17be43
gh-143959: Make _types optional for test_types
youknowone Jan 19, 2026
52b0e16
Merge remote-tracking branch 'upstream/main' into test_types-_datetime
youknowone Feb 19, 2026
9fcb7a4
Skip test_capsule_type when no _types
youknowone Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip test_capsule_type when no _types
  • Loading branch information
@youknowone
youknowone committed Feb 19, 2026
commit 9fcb7a441bc03f3fe7c642777d15e66d08082812
2 changes: 1 addition & 1 deletion Lib/test/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ def test_traceback_and_frame_types(self):
self.assertIsInstance(exc.__traceback__, types.TracebackType)
self.assertIsInstance(exc.__traceback__.tb_frame, types.FrameType)

@unittest.skipUnless(_datetime, "requires _datetime module")
@unittest.skipUnless(_types and _datetime, "requires _datetime module")
def test_capsule_type(self):
self.assertIsInstance(_datetime.datetime_CAPI, types.CapsuleType)

@serhiy-storchaka serhiy-storchaka Feb 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_datetime is only used in this test, so we can import it locally. We can use test.support.import_module() to skip the test.

@serhiy-storchaka serhiy-storchaka Feb 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use test.support.get_attribute(types, 'CapsuleType') to skip the test if CapsuleType is not available.


Expand Down
Loading