Skip to content

gh-143959: Make _datetime optional for test_sys #144003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Jan 22, 2026
Merged

gh-143959: Make _datetime optional for test_sys #144003

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c881be5
gh-143959 make test_sys import _datetime inside the test
youknowone Jan 18, 2026
c9fa18d
place `import _datetime` upper its usage
youknowone Jan 21, 2026
102aae2
try _datetime and run check
youknowone Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
place import _datetime upper its usage
  • Loading branch information
@youknowone
youknowone committed Jan 21, 2026
commit c9fa18d0c2d9b99615a76a359bd437d2146ed651
3 changes: 1 addition & 2 deletions Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,8 +1565,6 @@ def test_default(self):
self.assertEqual(sys.getsizeof(True, -1), size('') + self.longdigit)

def test_objecttypes(self):
import _datetime

# check all types defined in Objects/
calcsize = struct.calcsize
size = test.support.calcobjsize
Expand Down Expand Up @@ -1743,6 +1741,7 @@ def delx(self): del self.__x
x = property(getx, setx, delx, "")
check(x, size('5Pi'))
# PyCapsule
import _datetime
check(_datetime.datetime_CAPI, size('6P'))

@vstinner vstinner Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @serhiy-storchaka requested, this line should only be run if _datetime is available. Something like:

try:
    import _datetime
except ImportError:
    pass
else:
    check(_datetime.datetime_CAPI, size('6P'))

@youknowone youknowone Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# rangeiterator
check(iter(range(1)), size('3l'))
Expand Down
Loading