Skip to content

gh-143831: Compare cells by identity in forward references #143848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 14 commits into from
Jan 19, 2026
Merged

gh-143831: Compare cells by identity in forward references #143848

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
55e07ae
Hash and compare cells by identity
johnslavik Jan 14, 2026
9194bbf
Merge branch 'main' into fix-forwardrefs-dont-hash-cells
johnslavik Jan 15, 2026
ff81d6a
Use appropriate semantics in `__eq__`
johnslavik Jan 16, 2026
6c36442
Add base test
johnslavik Jan 16, 2026
d8f5bc8
Test two paths
johnslavik Jan 16, 2026
348127f
Simplify first self-test
johnslavik Jan 16, 2026
bc86ed2
Fix first self-test (typo)
johnslavik Jan 16, 2026
d434a40
Fix second self-test (typo)
johnslavik Jan 16, 2026
1f36f76
Add news entry
johnslavik Jan 16, 2026
32a3bef
Re-run CI
johnslavik Jan 16, 2026
866aef1
Move self-tests to class level
johnslavik Jan 16, 2026
094f0f8
Fix typo in a test forwardref
johnslavik Jan 16, 2026
416c501
Use dict comprehensions instead of dict+zip
johnslavik Jan 18, 2026
4707033
Merge branch 'main' into fix-forwardrefs-dont-hash-cells
JelleZijlstra Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix first self-test (typo)
  • Loading branch information
@johnslavik
johnslavik committed Jan 16, 2026
commit bc86ed28159817f0e93759acd2eb80a93ab39798
2 changes: 1 addition & 1 deletion Lib/test/test_annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1886,7 +1886,7 @@ def two(_) -> C1 | C2:
self.assertNotEqual(hash(A.one_f), hash(A.one_f_ga1))

self.assertIsInstance(A.one_f_ga1.__cell__, types.CellType)
self.assertIs(A.one_f_ga1.__cell__, A.one_f_ga1.__cell__)
self.assertIs(A.one_f_ga1.__cell__, A.one_f_ga2.__cell__)

self.assertEqual(A.one_f_ga1, A.one_f_ga2)
self.assertEqual(hash(A.one_f_ga1), hash(A.one_f_ga2))
Expand Down
Loading