Skip to content

gh-143543: Fix re-entrant use-after-free in itertools.groupby #143738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 22 commits into from
Feb 9, 2026
Merged

gh-143543: Fix re-entrant use-after-free in itertools.groupby #143738

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e898626
gh-143543: Fix re-entrant use-after-free in itertools.groupby
VanshAgarwal24036 Jan 12, 2026
ba974bc
Fix whitespace per prek
VanshAgarwal24036 Jan 12, 2026
0debc2a
Add NEWS entry for itertools.groupby crash fix
VanshAgarwal24036 Jan 13, 2026
8d83176
Fix NEWS filename for gh-143543
VanshAgarwal24036 Jan 13, 2026
ca932bf
Fix NEWS entry type for gh-143543
VanshAgarwal24036 Jan 13, 2026
0e86303
Remove incorrect NEWS files for gh-143543
VanshAgarwal24036 Jan 13, 2026
740218c
Avoid borrowed references during groupby key comparison
VanshAgarwal24036 Jan 13, 2026
e3a54be
Clarify NEWS entry wording
VanshAgarwal24036 Jan 13, 2026
9983345
Fix refcounting during groupby key comparison
VanshAgarwal24036 Jan 13, 2026
1ea51c0
Add NEWS entry via blurb for itertools.groupby crash
VanshAgarwal24036 Jan 13, 2026
336c367
Fix duplicate variable declarations in groupby_next
VanshAgarwal24036 Jan 13, 2026
9cbe1a6
itertools: hold strong references during groupby key comparison
VanshAgarwal24036 Jan 13, 2026
8c61450
Clarify re-entrant groupby key comparison comment
VanshAgarwal24036 Jan 14, 2026
90e995b
Update Modules/itertoolsmodule.c
VanshAgarwal24036 Jan 14, 2026
4f2338f
Update Lib/test/test_itertools.py
VanshAgarwal24036 Jan 14, 2026
2cac26b
Simplify groupby re-entrancy test
VanshAgarwal24036 Jan 14, 2026
fed7db7
Move rcmp declaration and clarify re-entrancy comment
VanshAgarwal24036 Jan 14, 2026
4939083
Move comment before declarations and inline rcmp
VanshAgarwal24036 Jan 14, 2026
e42b9b4
Remove Extra lines
VanshAgarwal24036 Jan 14, 2026
e29c818
Remove extra Lines
VanshAgarwal24036 Jan 15, 2026
4be9d4f
Update Lib/test/test_itertools.py
VanshAgarwal24036 Feb 3, 2026
b48d388
Merge branch 'main' into gh-143543-groupby-uaf
encukou Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into gh-143543-groupby-uaf
  • Loading branch information
@encukou
encukou authored Feb 4, 2026
commit b48d388d3e00a96505f828134734c52d2fadc848

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.