Skip to content

gh-143421: Use new buffer to save optimized uops #143682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 12 commits into from
Jan 17, 2026
Merged

gh-143421: Use new buffer to save optimized uops #143682

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e771fd0
use add_op to save optimized uops
cocolato Jan 11, 2026
4a0db15
optimize code struct
cocolato Jan 11, 2026
25797cf
optimize code struct
cocolato Jan 12, 2026
618cb4f
Merge branch 'main' into feat/ADD_OP
cocolato Jan 12, 2026
57a22e9
regen cases
cocolato Jan 12, 2026
031d6e3
optimize code
cocolato Jan 12, 2026
45f8ce0
remove out_len
cocolato Jan 12, 2026
2969891
Merge branch 'main' into feat/ADD_OP
cocolato Jan 12, 2026
0d07c5b
regen cases
cocolato Jan 12, 2026
15f32b9
move out_len to JitOptContext
cocolato Jan 12, 2026
543971c
remove cur_len
cocolato Jan 12, 2026
184196e
Merge branch 'main' into feat/ADD_OP
cocolato Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize code struct
  • Loading branch information
@cocolato
cocolato committed Jan 12, 2026
commit 25797cf308d8d5497f61bd45099bdc34ff9e3e88
14 changes: 10 additions & 4 deletions Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,6 @@ optimize_uops(
}
#endif

int out_len_before = ctx->tracer->out_len;
switch (opcode) {

#include "optimizer_cases.c.h"
Expand All @@ -428,7 +427,7 @@ optimize_uops(
Py_UNREACHABLE();
}
// If no ADD_OP was called during this iteration, copy the original instruction
if (ctx->tracer->out_len == out_len_before) {
if (ctx->tracer->out_len == i) {
ctx->tracer->out_buffer[ctx->tracer->out_len++] = *this_instr;
}
assert(ctx->frame != NULL);
Expand Down Expand Up @@ -461,8 +460,15 @@ optimize_uops(
_Py_uop_abstractcontext_fini(ctx);
// Check that the trace ends with a proper terminator
if (ctx->tracer->out_len > 0) {
if (!is_terminator_uop(&ctx->tracer->out_buffer[ctx->tracer->out_len - 1])) {
return 0;
_PyUOpInstruction *last_uop = &ctx->tracer->out_buffer[ctx->tracer->out_len - 1];
if (!is_terminator_uop(last_uop)) {
// Copy remaining uops from original trace until we find a terminator
for (int i = ctx->tracer->out_len; i < trace_len; i++) {
ctx->tracer->out_buffer[ctx->tracer->out_len++] = trace[i];
if (is_terminator_uop(&trace[i])) {
break;
}
}
}
}

Expand Down