Skip to content

gh-143650: Fix importlib race condition on import failure #143651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 5 commits into from
Feb 10, 2026
Merged

gh-143650: Fix importlib race condition on import failure #143651

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6393e97
Fix race condition in import system with failing imports
gpshead Jan 10, 2026
0a682cd
shorten comment
gpshead Jan 10, 2026
842c160
Address review: handle import_get_module errors in race condition fix
gpshead Jan 10, 2026
102845b
remove extra decref, oops! (should've rerun buildbots afterall)
gpshead Jan 11, 2026
179d7bf
Merge branch 'main' into fix-import-race-condition
encukou Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove extra decref, oops! (should've rerun buildbots afterall)
  • Loading branch information
@gpshead
gpshead authored Jan 11, 2026
commit 102845b8b5f93935c3e6b4ec997797a02e2ed325
1 change: 0 additions & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3912,7 +3912,6 @@ PyImport_ImportModuleLevelObject(PyObject *name, PyObject *globals,
if (mod_check != mod) {
Py_XDECREF(mod_check);
if (_PyErr_Occurred(tstate)) {
Py_DECREF(mod);
goto error;
}
Py_DECREF(mod);
Expand Down
Loading