Skip to content

gh-143017: Improve performance of get and put for subinterpreter queues #143464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prithviraj-chaudhuri wants to merge 9 commits into from
Closed

gh-143017: Improve performance of get and put for subinterpreter queues #143464

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e1ae625
Used PyEvents in subinterpreter queues to wait for queue full and que…
prithviraj-chaudhuri Jan 6, 2026
40e6391
Merge branch 'main' into feature-143017
prithviraj-chaudhuri Jan 6, 2026
2cea941
Changed event object names
prithviraj-chaudhuri Jan 7, 2026
ecab230
Added block keywords queue.get and queue.put
prithviraj-chaudhuri Jan 9, 2026
8bda61c
Updated queue arguments
prithviraj-chaudhuri Jan 9, 2026
12ec237
Merge branch 'main' into feature-143017
prithviraj-chaudhuri Jan 17, 2026
37bdcc8
Updating event variables while the queue is locked
prithviraj-chaudhuri Jan 24, 2026
821c72e
Merge branch 'main' into feature-143017
prithviraj-chaudhuri Jan 24, 2026
d138b27
Non blocking queue implementation in progress
prithviraj-chaudhuri Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Non blocking queue implementation in progress
  • Loading branch information
@prithviraj-chaudhuri
prithviraj-chaudhuri committed Feb 12, 2026
commit d138b27da0944424fc762ca4135daad0849064c8
9 changes: 9 additions & 0 deletions Modules/_interpqueuesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,8 @@ _queue_kill_and_wait(_queue *queue)
PyThread_acquire_lock(queue->mutex, WAIT_LOCK);
assert(queue->alive);
queue->alive = 0;
queue->space_available = (PyEvent){1};
queue->has_item = (PyEvent){1};
PyThread_release_lock(queue->mutex);

// Wait for all waiters to fail.
Expand Down Expand Up @@ -1147,7 +1149,9 @@ queue_put(_queues *queues, int64_t qid, PyObject *obj, unboundop_t unboundop,

// Wait for the queue to have space
if (block == 1) {
_queue_mark_waiter(queue, queues->mutex);
PyEvent_Wait(&queue->space_available);
_queue_unmark_waiter(queue, queues->mutex);
}

// Convert the object to cross-interpreter data.
Expand Down Expand Up @@ -1198,7 +1202,12 @@ queue_get(_queues *queues, int64_t qid,

// Wait for the queue to have some value
if (block == 1) {
_queue_mark_waiter(queue, queues->mutex);
PyEvent_Wait(&queue->has_item);
_queue_unmark_waiter(queue, queues->mutex);
if (!queue->alive) {
return ERR_QUEUE_NOT_FOUND;
}
}

// Pop off the next item from the queue.
Expand Down
Loading