Skip to content

gh-134584: Eliminate redundant refcounting from _CALL{_BUILTIN_O, _METHOD_DESCRIPTOR_O} #143330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 7 commits into from
Jan 1, 2026
Merged

gh-134584: Eliminate redundant refcounting from _CALL{_BUILTIN_O, _METHOD_DESCRIPTOR_O} #143330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a66fc14
gh-134584: Eliminate redundant refcounting from _CALL_METHOD_DESCRIPT…
corona10 Jan 1, 2026
88d3fa3
Update for _CALL_BUILTIN_O
corona10 Jan 1, 2026
fc99b86
Update
corona10 Jan 1, 2026
216440a
fix
corona10 Jan 1, 2026
760a9c2
fixup
Fidget-Spinner Jan 1, 2026
d86cd72
fix refleak problems
Fidget-Spinner Jan 1, 2026
3e6fe60
fix optimizer
Fidget-Spinner Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix refleak problems
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jan 1, 2026
commit d86cd72e458cdceb1c7124fafd7cc9b53b4ea2eb
2 changes: 1 addition & 1 deletion Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4170,7 +4170,7 @@ dummy_func(
_CALL_BUILTIN_CLASS +
_CHECK_PERIODIC_AT_END;

op(_CALL_BUILTIN_O, (callable, self_or_null, args[oparg] -- res, c, s, a)) {
op(_CALL_BUILTIN_O, (callable, self_or_null, args[oparg] -- res, c, s)) {
/* Builtin METH_O functions */
PyObject *callable_o = PyStackRef_AsPyObjectBorrow(callable);

Expand All @@ -4194,8 +4194,7 @@ dummy_func(
ERROR_NO_POP();
}
c = callable;
s = self_or_null;
a = args[0];
s = args[0];
INPUTS_DEAD();
res = PyStackRef_FromPyObjectSteal(res_o);
}
Expand All @@ -4206,7 +4205,6 @@ dummy_func(
_CALL_BUILTIN_O +
POP_TOP +
POP_TOP +
POP_TOP +
_CHECK_PERIODIC_AT_END;

op(_CALL_BUILTIN_FAST, (callable, self_or_null, args[oparg] -- res)) {
Expand Down Expand Up @@ -4396,8 +4394,8 @@ dummy_func(
ERROR_NO_POP();
}
c = callable;
s = self_or_null;
a = args[0];
s = arguments[0];
a = arguments[1];
INPUTS_DEAD();
res = PyStackRef_FromPyObjectSteal(res_o);
}
Expand Down
17 changes: 7 additions & 10 deletions Python/executor_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 5 additions & 17 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 10 additions & 5 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,18 +1064,23 @@ dummy_func(void) {
none = sym_new_const(ctx, Py_None);
}

op(_CALL_BUILTIN_O, (callable, self_or_null, args[oparg] -- res, c, s, a)) {
op(_CALL_BUILTIN_O, (callable, self_or_null, args[oparg] -- res, c, s)) {
res = sym_new_not_null(ctx);
c = callable;
s = self_or_null;
a = args[0];
if (sym_is_not_null(self_or_null)) {
args--;
}
s = args[0];
}

op(_CALL_METHOD_DESCRIPTOR_O, (callable, self_or_null, args[oparg] -- res, c, s, a)) {
res = sym_new_not_null(ctx);
c = callable;
s = self_or_null;
a = args[0];
if (sym_is_not_null(self_or_null)) {
args--;
}
s = args[0];
a = args[1];
}

op(_GUARD_IS_FALSE_POP, (flag -- )) {
Expand Down
19 changes: 11 additions & 8 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading