Skip to content

bpo-20181: Convert the readline module to the Argument Clinic #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Jul 12, 2020
Merged

bpo-20181: Convert the readline module to the Argument Clinic #14326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c28735
bpo-20181: Convert the readline module to the Argument Clinic
ZackerySpytz Jun 23, 2019
3eef9e1
Apply suggestions from code review
ZackerySpytz Jul 11, 2020
348ced6
Merge remote-tracking branch 'upstream/master' into bpo-20181-readlin…
ZackerySpytz Jul 11, 2020
ff5aaa2
make clinic
ZackerySpytz Jul 11, 2020
9d043a0
Tweaks
ZackerySpytz Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make clinic
  • Loading branch information
@ZackerySpytz
ZackerySpytz committed Jul 11, 2020
commit ff5aaa2400468e66ae1b73dc84a295ddbc1fdd7a
38 changes: 6 additions & 32 deletions Modules/clinic/readline.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Modules/readline.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ A negative length is used to inhibit history truncation.

static PyObject *
readline_set_history_length_impl(PyObject *module, int length)
/*[clinic end generated code: output=e161a53e45987dc7 input=52c7b9672cf3c9ac]*/
/*[clinic end generated code: output=e161a53e45987dc7 input=b8901bf16488b760]*/
{
_history_length = length;
Py_RETURN_NONE;
Expand All @@ -359,7 +359,7 @@ Return the maximum number of lines that will be written to the history file.

static PyObject *
readline_get_history_length_impl(PyObject *module)
/*[clinic end generated code: output=83a2eeae35b6d2b9 input=d84785889db06a55]*/
/*[clinic end generated code: output=83a2eeae35b6d2b9 input=5dce2eeba4327817]*/
{
return PyLong_FromLong(_history_length);
}
Expand Down Expand Up @@ -493,7 +493,7 @@ Get the beginning index of the completion scope.

static PyObject *
readline_get_begidx_impl(PyObject *module)
/*[clinic end generated code: output=362616ee8ed1b2b1 input=45f93049a7e94e32]*/
/*[clinic end generated code: output=362616ee8ed1b2b1 input=e083b81c8eb4bac3]*/
{
Py_INCREF(readlinestate_global->begidx);
return readlinestate_global->begidx;
Expand Down