Skip to content

gh-141671: PyMODINIT_FUNC: apply __declspec(dllexport) on Windows #141672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 11 commits into from
Jan 7, 2026
Merged

gh-141671: PyMODINIT_FUNC: apply __declspec(dllexport) on Windows #141672

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39d18d1
gh-141671: Use __declspec(dllexport) when not building core
encukou Nov 17, 2025
ad9110c
blurb
encukou Nov 17, 2025
fd34aff
Use _PyINIT_EXPORTED_SYMBOL
encukou Nov 18, 2025
c0e0a83
Use `__declspec(dllexport)` outside core
encukou Nov 18, 2025
5abc323
Allow embedders to customize
encukou Nov 18, 2025
82ad329
Remove duplication with defaults
encukou Nov 18, 2025
35a088a
Remove duplication with default
encukou Nov 18, 2025
b39a5a8
Reduce diff
encukou Nov 18, 2025
13da2c0
Merge in the main branch
encukou Dec 16, 2025
5091b79
Link macro that's now documented
encukou Dec 16, 2025
8818fae
Merge branch 'main' into pymodexport-always-export
encukou Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce diff
  • Loading branch information
@encukou
encukou committed Nov 18, 2025
commit b39a5a80563445e661f866b53424fc4d1531b58d
1 change: 0 additions & 1 deletion Include/exports.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
# define HAVE_DECLSPEC_DLL
#endif


#if defined(_WIN32) || defined(__CYGWIN__)
#if defined(Py_ENABLE_SHARED)
#define Py_IMPORTED_SYMBOL __declspec(dllimport)
Expand Down