Skip to content

gh-103740: Improve support of __slots__ for variable-length classes #141636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhiy-storchaka wants to merge 4 commits into from
Closed

gh-103740: Improve support of __slots__ for variable-length classes #141636

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c17b254
gh-103740: Improve support of __slots__ for variable-length classes
serhiy-storchaka Nov 16, 2025
7223cd5
Update Doc/whatsnew/3.15.rst
serhiy-storchaka Nov 17, 2025
723dcaa
Update Misc/NEWS.d/next/Core_and_Builtins/2025-11-16-21-14-48.gh-issu…
serhiy-storchaka Nov 17, 2025
5846379
Apply suggestions from code review
serhiy-storchaka Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
  • Loading branch information
@serhiy-storchaka @encukou
serhiy-storchaka and encukou authored Nov 17, 2025
commit 584637981cc42a962bf54ae1b9f6d9a9ba4a31dc
8 changes: 4 additions & 4 deletions Doc/reference/datamodel.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2632,9 +2632,10 @@ Notes on using *__slots__*:

* :exc:`TypeError` will be raised if *__slots__* other than *__dict__* and
*__weakref__* are defined for a class derived from a
:c:member:`"variable-length" built-in type <PyTypeObject.tp_itemsize>`
without the :c:macro:`Py_TPFLAGS_ITEMS_AT_END` flag such as
:class:`int`, :class:`bytes`, and :class:`tuple`.
:c:member:`"variable-length" built-in type <PyTypeObject.tp_itemsize>`,
unless the C type is defined with :c:macro:`Py_TPFLAGS_ITEMS_AT_END`.
For example, *__slots__* other than *__dict__* and *__weakref__* cannot
be defined on subclasses of :class:`int`, :class:`bytes`, or :class:`tuple`.
Comment on lines +2637 to +2638

@serhiy-storchaka serhiy-storchaka Nov 17, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use "they"?

Suggested change
For example, *__slots__* other than *__dict__* and *__weakref__* cannot
be defined on subclasses of :class:`int`, :class:`bytes`, or :class:`tuple`.
For example, they cannot be defined on subclasses of
:class:`int`, :class:`bytes`, or :class:`tuple`.


* Any non-string :term:`iterable` may be assigned to *__slots__*.

Expand All @@ -2659,7 +2660,6 @@ Notes on using *__slots__*:

.. versionchanged:: next
Allowed defining the *__dict__* and *__weakref__* *__slots__* for any class.

Allowed defining any *__slots__* for a class derived from :class:`type` or
other :c:member:`"variable-length" built-in type <PyTypeObject.tp_itemsize>`
with the :c:macro:`Py_TPFLAGS_ITEMS_AT_END` flag.
Expand Down
Loading