Skip to content

gh-140011: Delete importdl assertion that prevents importing embedded modules from packages #141605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 8 commits into from
Nov 26, 2025
Merged

gh-140011: Delete importdl assertion that prevents importing embedded modules from packages #141605

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4949865
Modify test embed to hit the assertion
itamaro Nov 16, 2025
34e81ce
Delete the assertion
itamaro Nov 16, 2025
108b14f
Merge branch 'main' into gh-140011-dotted-import
itamaro Nov 23, 2025
783da04
Revert "Modify test embed to hit the assertion"
itamaro Nov 23, 2025
f091794
Add tests for importing a submodule via inittab
itamaro Nov 23, 2025
45b1b9c
trim trailing whitespace
itamaro Nov 23, 2025
36dd0fe
Update Programs/_testembed.c
itamaro Nov 26, 2025
9d61f7a
Update Programs/_testembed.c
itamaro Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Modify test embed to hit the assertion" 
This reverts commit 4949865.
  • Loading branch information
@itamaro
itamaro committed Nov 23, 2025
commit 783da04fc5b0be6edd1c3c6a828d3567f515c085
6 changes: 3 additions & 3 deletions Programs/_testembed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2260,7 +2260,7 @@ static PyMethodDef create_static_module_methods[] = {

static struct PyModuleDef create_static_module_def = {
PyModuleDef_HEAD_INIT,
.m_name = "test.create_static_module",
.m_name = "create_static_module",
.m_size = 0,
.m_methods = create_static_module_methods,
.m_slots = extension_slots,
Expand All @@ -2287,7 +2287,7 @@ test_create_module_from_initfunc(void)
L"print(f'{embedded_ext.executed=}');"
};
PyConfig config;
if (PyImport_AppendInittab("test.create_static_module",
if (PyImport_AppendInittab("create_static_module",
&PyInit_create_static_module) != 0) {
fprintf(stderr, "PyImport_AppendInittab() failed\n");
return 1;
Expand All @@ -2299,7 +2299,7 @@ test_create_module_from_initfunc(void)
int result = PyRun_SimpleString(
"import sys\n"
"from importlib.util import spec_from_loader\n"
"from test import create_static_module\n"
"import create_static_module\n"
"class StaticExtensionImporter:\n"
" _ORIGIN = \"static-extension\"\n"
" @classmethod\n"
Expand Down