Skip to content

gh-141498: Change backoff counter to use prime numbers instead of powers of 2 #141591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 21 commits into from
Nov 21, 2025
Merged

gh-141498: Change backoff counter to use prime numbers instead of powers of 2 #141591

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
86de63a
Some refactor
efimov-mikhail Nov 15, 2025
4eb3231
Changes in backoff bit pattern
efimov-mikhail Nov 15, 2025
2581629
Add NEWS
efimov-mikhail Nov 15, 2025
96de415
NEWS fix
efimov-mikhail Nov 15, 2025
ce3e14f
Change ITEMS count in test
efimov-mikhail Nov 15, 2025
e17b195
Refactor restart_backoff_counter
efimov-mikhail Nov 19, 2025
44b4eb8
Remove unneed assertion and function
efimov-mikhail Nov 19, 2025
6d44333
Use lookup_table
efimov-mikhail Nov 19, 2025
0e05712
Use MAKE_BACKOFF_COUNTER macro
efimov-mikhail Nov 19, 2025
f3c9287
Comment change
efimov-mikhail Nov 19, 2025
e16b368
Fix Windows build: remove const keyword
efimov-mikhail Nov 19, 2025
6b1fe66
Simplify obtaining next backoff
efimov-mikhail Nov 19, 2025
2600236
Remove forge_backoff_counter
efimov-mikhail Nov 19, 2025
ec27072
Another try to fix Windows build
efimov-mikhail Nov 19, 2025
401b6da
Revert make_backoff_counter
efimov-mikhail Nov 19, 2025
3418be1
Revert changes to pycore_code.h
efimov-mikhail Nov 19, 2025
ceddb6a
Comment fix
efimov-mikhail Nov 19, 2025
a89d6de
Temporarily disable assert
efimov-mikhail Nov 19, 2025
c7873c2
Revert forge_backoff_counter
efimov-mikhail Nov 19, 2025
5b7bfd9
Fix CI, NEWS updated
efimov-mikhail Nov 19, 2025
dda4cdb
Review addressed: change values and comment
efimov-mikhail Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Temporarily disable assert
  • Loading branch information
@efimov-mikhail
efimov-mikhail committed Nov 19, 2025
commit a89d6decfbbe4aeed4a49e14b930acf48b0cbc44
2 changes: 1 addition & 1 deletion Include/internal/pycore_backoff.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ static uint16_t value_and_backoff_next[] = {
static inline _Py_BackoffCounter
make_backoff_counter(uint16_t value, uint16_t backoff)
{
assert(backoff <= UNREACHABLE_BACKOFF);
//assert(backoff <= UNREACHABLE_BACKOFF);
assert(value <= MAX_VALUE);
return ((_Py_BackoffCounter){
.value_and_backoff = MAKE_VALUE_AND_BACKOFF(value, backoff)
Expand Down
Loading