Skip to content

gh-139109: JIT _EXIT_TRACE to ENTER_EXECUTOR rather than _DEOPT #141573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 5 commits into from
Nov 15, 2025
Merged

gh-139109: JIT _EXIT_TRACE to ENTER_EXECUTOR rather than _DEOPT #141573

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9eac0f
JIT: _EXIT_TRACE to ENTER_EXECUTOR rather than _DEOPT
Fidget-Spinner Nov 14, 2025
2cf4f58
Add a test
Fidget-Spinner Nov 14, 2025
ca89c3c
spelling
Fidget-Spinner Nov 14, 2025
2d735c3
Fix test
Fidget-Spinner Nov 15, 2025
93c9226
Update test_opt.py
Fidget-Spinner Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Nov 14, 2025
commit 2cf4f585f2010a73dc1803e48206ff66698466bf
23 changes: 23 additions & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,17 @@ def get_first_executor(func):
pass
return None

def get_all_executors(func):
code = func.__code__
co_code = code.co_code
execs = []
Comment thread
Fidget-Spinner marked this conversation as resolved.
Outdated
for i in range(0, len(co_code), 2):
try:
execs.append(_opcode.get_executor(code, i))
except ValueError:
pass
return execs


def iter_opnames(ex):
for item in ex:
Expand Down Expand Up @@ -2629,6 +2640,18 @@ def gen():
next(g)
""" % _testinternalcapi.SPECIALIZATION_THRESHOLD))

def test_executor_side_exits_create_another_executor(self):
def f():
for x in range(TIER2_THRESHOLD + 3):
for y in range(TIER2_THRESHOLD + 3):
z = x + y

f()
# Inner loop warms up first.
# Outer loop warms up later, linking to the innter one.
# Therefore, at least two executors.
Comment thread
Fidget-Spinner marked this conversation as resolved.
Outdated
self.assertGreaterEqual(len(get_all_executors(f)), 2)

@efimov-mikhail efimov-mikhail Nov 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain, why this test checks _DEOPT vs _EXIT_TRACE pair?
On my machine it passes both on this PR and on main branch.
Using option --enable-experimental-jit=interpreter or --enable-experimental-jit=yes also doesn't matter.

@Fidget-Spinner Fidget-Spinner Nov 15, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm it shouldn't pass on main. Let me strengthen the test.

@efimov-mikhail efimov-mikhail Nov 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of test fails on main with --enable-experimental-jit=interpreter or with --enable-experimental-jit=yes as expected.



def global_identity(x):
return x
Expand Down
Loading