Skip to content

gh-141174: Improve annotationlib.get_annotations() test coverage #141286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 5 commits into from
Nov 10, 2025
Merged

gh-141174: Improve annotationlib.get_annotations() test coverage #141286

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9793ccb
Test `get_annotations(format=Format.VALUE)` for stringized annotation…
dr-carlos Nov 8, 2025
cf73525
Test `get_annotations(format=Format.VALUE)` for stringized annotation…
dr-carlos Nov 9, 2025
1c2ead8
Update test_stringized_annotations_with_star_unpack() to actually tes…
dr-carlos Nov 9, 2025
b231e29
Test __annotate__ returning a non-dict
dr-carlos Nov 9, 2025
918e45a
Test passing globals and locals to stringized `get_annotations()`
dr-carlos Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test get_annotations(format=Format.VALUE) for stringized annotation… 
…s on wrapped partial functions
  • Loading branch information
@dr-carlos
dr-carlos committed Nov 9, 2025
commit cf735258dea1b3551e3045ac3d89d8481ea6397a
39 changes: 39 additions & 0 deletions Lib/test/test_annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pickle
from string.templatelib import Template, Interpolation
import typing
import sys
import unittest
from annotationlib import (
Format,
Expand Down Expand Up @@ -811,6 +812,44 @@ def test_stringized_annotations_on_wrapper(self):
{"a": "int", "b": "str", "return": "MyClass"},
)

def test_stringized_annotations_on_partial_wrapper(self):
isa = inspect_stringized_annotations

def times_three_str(fn: typing.Callable[[str], isa.MyClass]):
@functools.wraps(fn)
def wrapper(b: "str") -> "MyClass":
return fn(b * 3)

return wrapper

wrapped = times_three_str(functools.partial(isa.function, 1))
self.assertEqual(wrapped("x"), isa.MyClass(1, "xxx"))
self.assertIsNot(wrapped.__globals__, isa.function.__globals__)
self.assertEqual(
get_annotations(wrapped, eval_str=True),
{"b": str, "return": isa.MyClass},
)
self.assertEqual(
get_annotations(wrapped, eval_str=False),
{"b": "str", "return": "MyClass"},
)

# If functools is not loaded, names will be evaluated in the current
# module instead of being unwrapped to the original.
functools_mod = sys.modules["functools"]
del sys.modules["functools"]

self.assertEqual(
get_annotations(wrapped, eval_str=True),
{"b": str, "return": MyClass},
)
self.assertEqual(
get_annotations(wrapped, eval_str=False),
{"b": "str", "return": "MyClass"},
)

sys.modules["functools"] = functools_mod

def test_stringized_annotations_on_class(self):
isa = inspect_stringized_annotations
# test that local namespace lookups work
Expand Down