Skip to content

gh-141174: Improve annotationlib.call_annotate_function() test coverage #141176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
Nov 10, 2025
Merged

gh-141174: Improve annotationlib.call_annotate_function() test coverage #141176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06d8832
Test passing unsupported Format values to call_annotate_function()
dr-carlos Nov 6, 2025
3910c6e
Test call_evaluate_function with fake globals that raise errors
dr-carlos Nov 6, 2025
5d60170
Fix typo and comparison in test_fake_global_evaluation
dr-carlos Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test call_evaluate_function with fake globals that raise errors
  • Loading branch information
@dr-carlos
dr-carlos committed Nov 6, 2025
commit 3910c6e6afb6c8d9dd2bc0e89e86085d6ecde830
26 changes: 26 additions & 0 deletions Lib/test/test_annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,32 @@ def evaluate(format, exc=NotImplementedError):
"undefined",
)

def test_fake_global_evaluation(self):
# This will raise an AttributeError
def evaluate_union(format, exc=NotImplementedError):
if format == Format.VALUE_WITH_FAKE_GLOBALS:
# Return a ForwardRef
return builtins.undefined | list[int]
raise exc

self.assertEqual(
annotationlib.call_evaluate_function(evaluate_union, Format.FORWARDREF),
support.EqualToForwardRef("builtins.undef | list[int]"),
)

# This will raise an AttributeError
def evaluate_intermediate(format, exc=NotImplementedError):
if format == Format.VALUE_WITH_FAKE_GLOBALS:
intermediate = builtins.undefined
# Return a literal
return intermediate == builtins.defined
raise exc

self.assertIs(
annotationlib.call_evaluate_function(evaluate_intermediate, Format.FORWARDREF),
False,
)


class TestCallAnnotateFunction(unittest.TestCase):
# Tests for user defined annotate functions.
Expand Down
Loading