Skip to content

gh-140939: Fix memory leak in _PyBytes_FormatEx error path #140957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 5 commits into from
Nov 6, 2025
Merged

gh-140939: Fix memory leak in _PyBytes_FormatEx error path #140957

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0f7903
Commit
StanFromIreland Nov 3, 2025
fcf8d1b
Catch OverflowError too
StanFromIreland Nov 3, 2025
2640e6e
Remove loop per Victor's review
StanFromIreland Nov 5, 2025
99d1b6b
_testcapi.PY_SSIZE_T_MAX
StanFromIreland Nov 5, 2025
873679f
Move test
StanFromIreland Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
_testcapi.PY_SSIZE_T_MAX
  • Loading branch information
@StanFromIreland
StanFromIreland committed Nov 5, 2025
commit 99d1b6b83e71befa4982adbe777196aea463ab63
5 changes: 3 additions & 2 deletions Lib/test/test_bytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,9 +803,10 @@ def __int__(self):
operator.mod(format_bytes, value)

# gh-140939: MemoryError is raised without leaking
Comment thread
StanFromIreland marked this conversation as resolved.
with self.assertRaises((MemoryError, OverflowError)):
_testcapi = import_helper.import_module('_testcapi')
with self.assertRaises(MemoryError):
b = self.type2test(b'%*b')
b % (2**63-1, b'abc')
b % (_testcapi.PY_SSIZE_T_MAX, b'abc')

def test_imod(self):
b = self.type2test(b'hello, %b!')
Expand Down
Loading