Skip to content

gh-140815: Fix faulthandler for invalid/freed frame #140921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 8 commits into from
Nov 4, 2025
Merged

gh-140815: Fix faulthandler for invalid/freed frame #140921

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cab1e5
gh-140815: Fix faulthandler for invalid/freed frame
vstinner Oct 31, 2025
4059837
Add NEWS entry
vstinner Nov 2, 2025
9b26187
Address reviews
vstinner Nov 2, 2025
7d9a4b8
Update Include/internal/pycore_code.h
vstinner Nov 2, 2025
c208539
Enhance _PyMem_IsPtrFreed()
vstinner Nov 3, 2025
c273f99
Stricter _PyFrame_SafeGetCode()
vstinner Nov 3, 2025
3764548
coding style
vstinner Nov 3, 2025
6239435
Document that safe functions are not 100% reliable
vstinner Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhance _PyMem_IsPtrFreed()
  • Loading branch information
@vstinner
vstinner committed Nov 3, 2025
commit c208539d35987e13c2c9e3a5eefef05c8807b8aa
10 changes: 6 additions & 4 deletions Include/internal/pycore_pymem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,17 @@ static inline int _PyMem_IsPtrFreed(const void *ptr)
{
uintptr_t value = (uintptr_t)ptr;
#if SIZEOF_VOID_P == 8
return (value < 256 // NULL, 0x1, 0x2, ...
return (value <= 0xff // NULL, 0x1, 0x2, ..., 0xff
|| value == (uintptr_t)0xCDCDCDCDCDCDCDCD
|| value == (uintptr_t)0xDDDDDDDDDDDDDDDD
|| value == (uintptr_t)0xFDFDFDFDFDFDFDFD);
|| value == (uintptr_t)0xFDFDFDFDFDFDFDFD
|| value >= (uintptr_t)0xFFFFFFFFFFFFFF00); // -0xff, ..., -2, -1
#elif SIZEOF_VOID_P == 4
return (value < 256
return (value <= 0xff
|| value == (uintptr_t)0xCDCDCDCD
|| value == (uintptr_t)0xDDDDDDDD
|| value == (uintptr_t)0xFDFDFDFD);
|| value == (uintptr_t)0xFDFDFDFD
|| value >= (uintptr_t)0xFFFFFF00);
#else
# error "unknown pointer size"
#endif
Expand Down